src: initialize FSReqWrapSync in path that uses it#56613
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 19, 2025
Merged
src: initialize FSReqWrapSync in path that uses it#56613nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
jasnell
approved these changes
Jan 15, 2025
Member
Author
|
Well it looks like this is breaking some tests. I'll come back to it when I'm on my Mac |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56613 +/- ##
==========================================
- Coverage 89.20% 89.19% -0.01%
==========================================
Files 662 662
Lines 191816 191819 +3
Branches 36926 36921 -5
==========================================
- Hits 171102 171090 -12
- Misses 13559 13571 +12
- Partials 7155 7158 +3
|
anonrig
approved these changes
Jan 15, 2025
targos
force-pushed
the
coverity_node_file
branch
from
2b07c23 to
d590d06
Compare
Member
Author
|
Apparently it's important that the stack_buffer still lives after use, so I updated to only change the variable that was flagged by Coverity. |
targos
changed the title
Member
Author
|
CI looks good now. Can I have a new review? |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
lpinca
approved these changes
Jan 17, 2025
jasnell
added
the
commit-queue
jasnell
approved these changes
Jan 19, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 322056d |
This was referenced Jan 28, 2025
Merged
This was referenced Mar 17, 2025
This was referenced Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to fix this error reported by Coverity: