diagnostics_channel: capture console messages #56292
Open
+146
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
added
console
Qard
force-pushed
the
console-diagnostics-channels
branch
from
6ba11e5 to
07fbcd4
Compare
github-actions
bot
removed
the
request-ci
Qard
force-pushed
the
console-diagnostics-channels
branch
from
07fbcd4 to
8094626
Compare
Qard
force-pushed
the
console-diagnostics-channels
branch
from
8094626 to
b3830bf
Compare
|
I lack context on this, so I might be missing some point. Can this use the Inspector protocol instead of adding hooks directly into console object. In-process inspector API can be configured to watch for the messages? This way there will be less coupling. |
|
The Inspector API is substantially more expensive. This is meant for being able to rewrite potentially all log messages in production, so it needs to be fast. |
|
Thanks for the reply. |
RafaelGSS
approved these changes
Dec 17, 2024
|
Maybe worth to extend test to verify adding/removing/replacing elements, Main problem I see with mutating diagnostics channels is the undefined sequence if there are more subscribers. |
Flarna
reviewed
Dec 17, 2024
|
|
||
| * `args` {any\[]} | ||
|
|
||
| Emitted when `console.log()` is called. Receives and array of the arguments |
There was a problem hiding this comment.
Maybe describe that this is the arguments array and therefore mutation is possible.
Flarna
approved these changes
Dec 17, 2024
cola119
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added diagnostics_channel support to capture and modify inputs to the main console methods. This enables some useful things like APMs injecting tracing data into log messages to correlate log messages to the requests from which they originated. You can also replace the args list entirely, so you could apply your own custom formatting to produce JSON logs instead or things like that.
cc @nodejs/diagnostics @nodejs/console