test: move hasMultiLocalhost to common/net #56716
Open
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that `common/net` already exists and hasMultiLocalhost is net specific, let's move it out of common/index to better encapsulate and simplify common/index more
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56716 +/- ##
=======================================
Coverage 89.20% 89.21%
=======================================
Files 662 662
Lines 191934 191934
Branches 36944 36952 +8
=======================================
+ Hits 171218 171230 +12
+ Misses 13552 13536 -16
- Partials 7164 7168 +4 |
richardlau
approved these changes
Jan 23, 2025
lpinca
approved these changes
Jan 23, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
jasnell
added
the
commit-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
common/netalready exists and hasMultiLocalhost is net specific, let's move it out of common/index to better encapsulate and simplify common/index more