Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor --trace-env to reuse option selection and handling #56293

Merged
merged 2 commits into from
Jan 9, 2025
Merged

src: refactor --trace-env to reuse option selection and handling #56293

merged 2 commits into from
Jan 9, 2025
+93 −78

Conversation

joyeecheung
Copy link
Member

This reduces the duplication in the code base, also makes makes the log messages more concise since the [--trace-env] prefix should provide enough indication about the fact that it's about environment variable access.

@joyeecheung
src: refactor --trace-env to reuse option selection and handling
3c65551 
This reduces the duplication in the code base, also makes
makes the log messages more concise since the `[--trace-env]`
prefix should provide enough indication about the fact that
it's about environment variable access.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 17, 2024
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@joyeecheung
Copy link
Member Author

cc @nodejs/cpp-reviewers

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64087/

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.13%. Comparing base (a50f3d5) to head (c667dad).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
src/node_env_var.cc 97.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56293      +/-   ##
==========================================
+ Coverage   88.55%   89.13%   +0.58%     
==========================================
  Files         657      662       +5     
  Lines      190243   191559    +1316     
  Branches    36536    36860     +324     
==========================================
+ Hits       168461   170748    +2287     
+ Misses      14963    13686    -1277     
- Partials     6819     7125     +306
Files with missing lines Coverage Δ
src/node_credentials.cc 68.72% <100.00%> (-0.56%) ⬇️
src/node_internals.h 81.03% <ø> (ø)
src/node_env_var.cc 86.85% <97.77%> (-0.26%) ⬇️

... and 136 files with indirect coverage changes

H4ad
H4ad approved these changes Dec 21, 2024
View reviewed changes
test/parallel/test-trace-env.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64147/

legendecas
legendecas reviewed Dec 31, 2024
View reviewed changes
src/node_internals.h Outdated Show resolved Hide resolved
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64391/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64403/

@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit 6b3937a into nodejs:main Jan 9, 2025
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6b3937a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@legendecas legendecas legendecas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @nodejs-github-bot @jasnell @legendecas @H4ad