docs: clarify that WASM is trusted #56345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
aduh95
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Can you move that to the point number 3 The code it is asked to run?
Lines 114 to 117 in d1b8b5c
Also, the subsystem should be doc:, not docs:
marco-ippolito
approved these changes
Dec 23, 2024
UlisesGascon
approved these changes
Dec 23, 2024
lpinca
approved these changes
Dec 23, 2024
RafaelGSS
approved these changes
Dec 23, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
clarify-that-wasm-is-truested
branch
from
ac86b0d to
e4cca8c
Compare
aduh95
approved these changes
Dec 24, 2024
| @@ -111,8 +111,8 @@ lead to a loss of confidentiality, integrity, or availability. | |||
| 1. The developers and infrastructure that runs it. | |||
| 2. The operating system that Node.js is running under and its configuration, | |||
| along with anything under control of the operating system. | |||
| 3. The code it is asked to run, including JavaScript and native code, even if | |||
| said code is dynamically loaded, e.g., all dependencies installed from the | |||
| 3. The code it is asked to run, including JavaScript, WASM and native code, even | |||
There was a problem hiding this comment.
Nit: Oxford comma
Suggested change
| 3. The code it is asked to run, including JavaScript, WASM and native code, even | |
| 3. The code it is asked to run, including JavaScript, WASM, and native code, even |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies that WASM is trusted, too.