-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip test-sqlinte-extension
when SQLite is not built by us
#56341
base: main
Are you sure you want to change the base?
Conversation
Can't we build the extension even when |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56341 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 657 657
Lines 190395 190395
Branches 36552 36549 -3
==========================================
- Hits 168580 168579 -1
- Misses 14993 14994 +1
Partials 6822 6822 |
I don't know maybe, but until that happens, we should skip this test as its failure does not indicate an actual problem and is just plain annoying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the commit message
Refs: #53900 (comment)
The
libsqlite_extension
binary won't be found in the same directory asnode
when we build with--shared-sqlite
.