-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-api: define version 10 #55676
base: main
Are you sure you want to change the base?
node-api: define version 10 #55676
Conversation
Review requested:
|
0b45ca2
to
e7202ac
Compare
e7202ac
to
2e6c423
Compare
To discuss: |
2e6c423
to
b53c01a
Compare
b53c01a
to
a4176e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55676 +/- ##
=======================================
Coverage 88.54% 88.55%
=======================================
Files 657 657
Lines 190655 190657 +2
Branches 36582 36585 +3
=======================================
+ Hits 168824 168829 +5
+ Misses 15002 15001 -1
+ Partials 6829 6827 -2
|
c8e1c65
to
66d9b4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
Line 100 in d09458f
if (env->module_api_version < NAPI_VERSION_EXPERIMENTAL && |
66d9b4e
to
55f7681
Compare
Notable runtime changes to existing APIs: - returning `node_api_cannot_run_js` instead of `napi_pending_exception`. - allow creating references to objects, functions, and symbols.
55f7681
to
e9de692
Compare
@legendecas updated the PR. Please take another look! |
Notable runtime changes to existing APIs:
node_api_cannot_run_js
instead ofnapi_pending_exception
.