-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: increase iteration number to appropriate one #50861
Commits on Nov 23, 2023
-
benchmark: increase iteration number to appropriate one
Increase the iteration number from 500 to 2500 to make time consumption of crypto operation dominate the benchmark running. Fixes: nodejs#50571
Lei Shi committedNov 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 4207129 - Browse repository at this point
Copy the full SHA 4207129View commit details -
benchmark: increase get-ciphers iteration number to appropriate one
Increase the iteration number from 5000 to 500000 to make time consumption of crypto operation dominate the benchmark running. Fixes: nodejs#50571
Lei Shi committedNov 23, 2023 Configuration menu - View commit details
-
Copy full SHA for d99642a - Browse repository at this point
Copy the full SHA d99642aView commit details
Commits on Nov 27, 2023
-
build: disable flag v8_scriptormodule_legacy_lifetime
Usages of `v8::ScriptOrModule` were removed in nodejs#44198 so the flag can be disabled by default. PR-URL: nodejs#50616 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 186fe2c - Browse repository at this point
Copy the full SHA 186fe2cView commit details -
permission: mark const functions as such
Otherwise, non-mutating functions such as is_tree_granted unnecessarily require pointers to mutable data structures. PR-URL: nodejs#50705 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Configuration menu - View commit details
-
Copy full SHA for 366d727 - Browse repository at this point
Copy the full SHA 366d727View commit details -
doc: update print results(detail) in
PerformanceEntry
PR-URL: nodejs#50723 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Jungku Lee authored and Lei Shi committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for eecb717 - Browse repository at this point
Copy the full SHA eecb717View commit details -
test: give more time to GC in test-shadow-realm-gc-*
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: nodejs#50735 Refs: nodejs#50726 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 377c28d - Browse repository at this point
Copy the full SHA 377c28dView commit details -
test: mark SEA tests as flaky on PowerPC
PR-URL: nodejs#50750 Refs: nodejs#50740 Refs: nodejs/reliability#718 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 1108a98 - Browse repository at this point
Copy the full SHA 1108a98View commit details -
build: fix GN configuration for deps/base64
PR-URL: nodejs#50696 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9cb0148 - Browse repository at this point
Copy the full SHA 9cb0148View commit details -
test: skip parallel/test-macos-app-sandbox if disk space < 120MB
It needs to copy the Node.js binary which is currently almost 100MB. To be safe, skip the test when the available disk space is smaller than 120MB. PR-URL: nodejs#50764 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4032f2 - Browse repository at this point
Copy the full SHA c4032f2View commit details -
test: improve test-bootstrap-modules.js
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in nodejs#45662. PR-URL: nodejs#50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1e72c91 - Browse repository at this point
Copy the full SHA 1e72c91View commit details -
perf_hooks: implement performance.now() with fast API calls
PR-URL: nodejs#50492 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for dfde215 - Browse repository at this point
Copy the full SHA dfde215View commit details -
benchmark: rewrite import.meta benchmark
This is a ESM benchmark, rewrite it so that we are directly benchmarking the ESM import.meta paths and using number of loads for op/s calculation, instead of doing it in startup benchmarks and nesting number of process/workers spawn for op/s calculation. PR-URL: nodejs#50683 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Configuration menu - View commit details
-
Copy full SHA for 6db3c64 - Browse repository at this point
Copy the full SHA 6db3c64View commit details -
PR-URL: nodejs#50772 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6304f7c - Browse repository at this point
Copy the full SHA 6304f7cView commit details -
doc: fix fs.writeFileSync return value documentation
In nodejs#50009, the return value was accidentally made part of `flush` option bullet point. PR-URL: nodejs#50760 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e83baa6 - Browse repository at this point
Copy the full SHA e83baa6View commit details -
test: replace forEach() with for-loop
PR-URL: nodejs#50596 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0169a09 - Browse repository at this point
Copy the full SHA 0169a09View commit details -
benchmark: increase the iteration number to an appropriate value
Current iteration number is too small that fwrite occupies large portion of execution time which made crypo execution time measured inaccurate. The iteration above 1e5 makes 50% higher and stable score. PR-URL: nodejs#50766 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Lei Shi committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for a9fa824 - Browse repository at this point
Copy the full SHA a9fa824View commit details -
stream: add Symbol.toStringTag to Compression Streams
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 426ca12 - Browse repository at this point
Copy the full SHA 426ca12View commit details -
stream: yield expected Error class on zlib errors
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d899d5e - Browse repository at this point
Copy the full SHA d899d5eView commit details -
test: update WPT files for WebIDL tests
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cbdf5a6 - Browse repository at this point
Copy the full SHA cbdf5a6View commit details -
src: remove erroneous default argument in RadixTree
This default argument can never benefit any potential caller because any call site that occurs after this definition will result in a compiler error due to RadixTree::Lookup(const std::string_view&) now being an ambiguous call target. PR-URL: nodejs#50736 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4831f25 - Browse repository at this point
Copy the full SHA 4831f25View commit details -
src: avoid copying strings in FSPermission::Apply
The use of string_view and subsequent copying to a string was supposed to be a minor optimization in 640a7918, however, since 413c16e, no string splitting occurs anymore. Therefore, we can simply pass around some references instead of using string_view or copying strings. Refs: nodejs#48491 Refs: nodejs#49047 PR-URL: nodejs#50662 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c801888 - Browse repository at this point
Copy the full SHA c801888View commit details -
test: replace forEach in whatwg-encoding-custom-interop
PR-URL: nodejs#50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 30415df - Browse repository at this point
Copy the full SHA 30415dfView commit details -
src: iterate on import attributes array correctly
The array's length is supposed to be a multiple of two for dynamic import callbacks. Fixes: nodejs#50700 PR-URL: nodejs#50703 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be26f4d - Browse repository at this point
Copy the full SHA be26f4dView commit details -
inspector: use private fields instead of symbols
PR-URL: nodejs#50776 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for a1cb897 - Browse repository at this point
Copy the full SHA a1cb897View commit details -
build: add configuration flag to enable Maglev
This adds a configuration flag to enable V8's Maglev compiler. Unfortunately compilation fails unless you have clang-14+ or gcc-13+, but I sent a patch for that upstream. Other than that, it builds and all tests pass locally on my x86-64 Linux machine. The gn scraper regexes were broken preventing the compilation from linking. Fix them. As a drive-by, also add additional conditionals for compilation on 32-bit arm. Refs: nodejs#50690 PR-URL: nodejs#50692 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a5cafc5 - Browse repository at this point
Copy the full SHA a5cafc5View commit details -
test: enable idlharness tests for encoding
TextDecoderStream and TextEncoderStream are now exposed as globals, so we can run the entire Encoding idlharness test suite. PR-URL: nodejs#50778 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3384dfd - Browse repository at this point
Copy the full SHA 3384dfdView commit details -
doc: update Crypto API doc for x509.keyUsage
PR-URL: nodejs#50603 Refs: nodejs#48727 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8eafec3 - Browse repository at this point
Copy the full SHA 8eafec3View commit details -
deps: V8: cherry-pick 475c8cdf9a95
Original commit message: [ptr-compr] Fix multi-cage mode This CL introduces PtrComprCageAccessScope which sets/restores current thread's pointer compression cage base values. It's supposed to be used by V8 jobs accessing V8 heap outside of v8::Isolate::Scope or i::LocalHeap or i::LocalIsolate scopes (they already ensure that the cage base values are properly initialized). For all other build modes PtrComprCageAccessScope is a no-op. For simplicity reasons the multi-cage mode is made incompatible with external code space. Bug: v8:13788, v8:14292 Change-Id: I06c2d19a1eb7254fa7af07a17617e22d98abea9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846592 Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#90075} Refs: v8/v8@475c8cd PR-URL: nodejs#50680 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14292 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e91566f - Browse repository at this point
Copy the full SHA e91566fView commit details -
src: add IsolateScopes before using isolates
The V8 API requires entering an isolate before using it. We were often not doing this, which worked fine in practice. However when (multi-cage) pointer compression is enabled, the correct isolate needs to be active in order to decompress pointers correctly, otherwise it causes crashes. Fix this by sprinkling in some calls to v8::Isolate::Scope::Scope where they were missing. This also introduces RAIIIsolateWithoutEntering which is used in JSONParser to avoid otherwise exposing the Isolate::Scope outside of the class. Tested by compiling with `--experimental-enable-pointer-compression` locally and running all tests. Refs: nodejs/build#3204 (comment) Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14292 PR-URL: nodejs#50680 Refs: v8/v8@475c8cd Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f4da4ab - Browse repository at this point
Copy the full SHA f4da4abView commit details -
test: use ppc and ppc64 to skip SEA tests on PowerPC
It seems using ppc alone is not enough. Add ppc64 to be safe. PR-URL: nodejs#50828 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me>
Configuration menu - View commit details
-
Copy full SHA for 7131119 - Browse repository at this point
Copy the full SHA 7131119View commit details -
deps: update minimatch to 9.0.3
PR-URL: nodejs#50806 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 696bfc4 - Browse repository at this point
Copy the full SHA 696bfc4View commit details -
tools: update lint-md-dependencies to rollup@4.5.0
PR-URL: nodejs#50807 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f236e17 - Browse repository at this point
Copy the full SHA f236e17View commit details -
tools: update eslint to 8.54.0
PR-URL: nodejs#50809 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f947592 - Browse repository at this point
Copy the full SHA f947592View commit details -
test: use requires instead of flaky in console WPT status
PR-URL: nodejs#50812 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 478d646 - Browse repository at this point
Copy the full SHA 478d646View commit details -
PR-URL: nodejs#50813 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d6a85d2 - Browse repository at this point
Copy the full SHA d6a85d2View commit details -
PR-URL: nodejs#50770 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8735574 - Browse repository at this point
Copy the full SHA 8735574View commit details -
test: replace forEach() with for ... of in test-tls-getprotocol.js
PR-URL: nodejs#50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 46c6e06 - Browse repository at this point
Copy the full SHA 46c6e06View commit details -
test: replace forEach with for-of in test-url-relative
PR-URL: nodejs#50788 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ecc8936 - Browse repository at this point
Copy the full SHA ecc8936View commit details -
stream: fix enumerability of ReadableStream.prototype.values
PR-URL: nodejs#50779 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5fc7bed - Browse repository at this point
Copy the full SHA 5fc7bedView commit details -
stream: fix enumerability of ReadableStream.from
PR-URL: nodejs#50779 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9266d1c - Browse repository at this point
Copy the full SHA 9266d1cView commit details -
test: add note about readable streams with type owning
PR-URL: nodejs#50779 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c21e806 - Browse repository at this point
Copy the full SHA c21e806View commit details -
test: add note about unresolved spec issue
PR-URL: nodejs#50779 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 042ea75 - Browse repository at this point
Copy the full SHA 042ea75View commit details -
PR-URL: nodejs#50815 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7793773 - Browse repository at this point
Copy the full SHA 7793773View commit details -
src: add
--disable-warning
optionCo-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#50661 Fixes: nodejs#30810 Fixes: nodejs#47478 Fixes: nodejs#46862 Fixes: nodejs#40940 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 61234ce - Browse repository at this point
Copy the full SHA 61234ceView commit details -
crypto: update root certificates to NSS 3.95
This is the certdata.txt[0] from NSS 3.95, released on 2023-11-16. This is the version of NSS that will ship in Firefox 121 on 2023-12-19. Certificates added: - TrustAsia Global Root CA G3 - TrustAsia Global Root CA G4 - CommScope Public Trust ECC Root-01 - CommScope Public Trust ECC Root-02 - CommScope Public Trust RSA Root-01 - CommScope Public Trust RSA Root-02 Certificates removed: - Autoridad de Certificacion Firmaprofesional CIF A62634068 [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_95_RTM/lib/ckfw/builtins/certdata.txt PR-URL: nodejs#50805 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d9c9b4 - Browse repository at this point
Copy the full SHA 9d9c9b4View commit details -
dns: call handle.setServers() with a valid array
`handle.setServers()` takes an array, not a string. PR-URL: nodejs#50811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9af0fb0 - Browse repository at this point
Copy the full SHA 9af0fb0View commit details -
PR-URL: nodejs#50515 Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
Configuration menu - View commit details
-
Copy full SHA for 354eb49 - Browse repository at this point
Copy the full SHA 354eb49View commit details -
build: add GN configurations for simdjson
PR-URL: nodejs#50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for a653bde - Browse repository at this point
Copy the full SHA a653bdeView commit details -
doc: fix typos in --allow-fs-*
Refs: nodejs#49047 PR-URL: nodejs#50845 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 802c11d - Browse repository at this point
Copy the full SHA 802c11dView commit details -
doc: add CanadaHonk to triagers
PR-URL: nodejs#50848 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c46275 - Browse repository at this point
Copy the full SHA 3c46275View commit details -
2023-11-22, Version 20.10.0 'Iron' (LTS)
Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908 doc: * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096 * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095 * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187 * call helper function from push and unshift (Raz Luvaton) nodejs#50173 * optimize Writable (Robert Nagy) nodejs#50012 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141 * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950 wasi: PR-URL: nodejs#50682
Configuration menu - View commit details
-
Copy full SHA for e36ce82 - Browse repository at this point
Copy the full SHA e36ce82View commit details -
src: fix compatility with upcoming V8 12.1 APIs
PR-URL: nodejs#50709 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0ad7229 - Browse repository at this point
Copy the full SHA 0ad7229View commit details -
tools: use macOS keychain to notarize the releases
PR-URL: nodejs#50715 Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 73e71ed - Browse repository at this point
Copy the full SHA 73e71edView commit details -
doc: create deprecation code for isWebAssemblyCompiledModule
PR-URL: nodejs#50486 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 38f3754 - Browse repository at this point
Copy the full SHA 38f3754View commit details -
permission: do not create symlinks if target is relative
The permission model's security guarantees fall apart in the presence of relative symbolic links. When an application attempts to create a relative symlink, the permission model currently resolves the relative path into an absolute path based on the process's current working directory, checks whether the process has the relevant permissions, and then creates the symlink using the absolute target path. This behavior is plainly incorrect for two reasons: 1. The target path should never be resolved relative to the current working directory. If anything, it should be resolved relative to the symlink's location. (Of course, there is one insane exception to this rule: on Windows, each process has a current working directory per drive, and symlinks can be created with a target path relative to the current working directory of a specific drive. In that case, the relative path will be resolved relative to the current working directory for the respective drive, and the symlink will be created on disk with the resulting absolute path. Other relative symlinks will be stored as-is.) 2. Silently creating an absolute symlink when the user requested a relative symlink is wrong. The user may (or may not) rely on the symlink being relative. For example, npm heavily relies on relative symbolic links such that node_modules directories can be moved around without breaking. Because we don't know the user's intentions, we don't know if creating an absolute symlink instead of a relative symlink is acceptable. This patch prevents the faulty behavior by not (incorrectly) resolving relative symlink targets when the permission model is enabled, and by instead simply refusing the create any relative symlinks. The fs APIs accept Uint8Array objects for paths to be able to handle arbitrary file name charsets, however, checking whether such an object represents a relative part in a reliable and portable manner is tricky. Other parts of the permission model incorrectly convert such objects to strings and then back to an Uint8Array (see 1f64147), however, for now, this bug fix will simply throw on non-string symlink targets when the permission model is enabled. (The permission model already breaks existing applications in various ways, so this shouldn't be too dramatic.) PR-URL: nodejs#49156 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2d550a2 - Browse repository at this point
Copy the full SHA 2d550a2View commit details -
doc: get rid of unnecessary
eslint-skip
commentsPR-URL: nodejs#50829 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 19ac425 - Browse repository at this point
Copy the full SHA 19ac425View commit details -
fs: improve error perf of sync
lstat
+fstat
PR-URL: nodejs#49868 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 154b8de - Browse repository at this point
Copy the full SHA 154b8deView commit details -
doc: shard not supported with watch mode
PR-URL: nodejs#50640 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for f2d4b88 - Browse repository at this point
Copy the full SHA f2d4b88View commit details -
test: replace foreach with for in test-https-simple.js
Fixes: nodejs#50818 PR-URL: nodejs#49793 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Shikha Mehta authored and Lei Shi committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 4a3ce61 - Browse repository at this point
Copy the full SHA 4a3ce61View commit details -
tools: add macOS notarization verification step
PR-URL: nodejs#50833 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 8b61c75 - Browse repository at this point
Copy the full SHA 8b61c75View commit details -
fs: replace deprecated
path._makeLong
in copyFilePR-URL: nodejs#50844 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ccd5bee - Browse repository at this point
Copy the full SHA ccd5beeView commit details -
deps: V8: cherry-pick 0f9ebbc672c7
Original commit message: [flags] Remove --harmony-string-is-well-formed The String.prototype.isWellFormed and toWellFormed have shipped since M111. Bug: v8:13557 Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Chengzhong Wu (legendecas) <legendecas@gmail.com> Cr-Commit-Position: refs/heads/main@{#90398} Refs: v8/v8@0f9ebbc PR-URL: nodejs#50867 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 4e92c1c - Browse repository at this point
Copy the full SHA 4e92c1cView commit details -
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
PR-URL: nodejs#50795 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 247915b - Browse repository at this point
Copy the full SHA 247915bView commit details -
test: replace forEach with for of
PR-URL: nodejs#50594 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6d4439a - Browse repository at this point
Copy the full SHA 6d4439aView commit details -
test: fix dns test case failures after c-ares update to 1.21.0+
c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: nodejs#50743 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Fixes: nodejs#50741 Refs: nodejs#50444
Configuration menu - View commit details
-
Copy full SHA for 5ecfb5c - Browse repository at this point
Copy the full SHA 5ecfb5cView commit details -
meta: move cjihrig to TSC regular member
PR-URL: nodejs#50816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 75a76a4 - Browse repository at this point
Copy the full SHA 75a76a4View commit details -
- reduce copying by using std::move Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#50846 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee14a96 - Browse repository at this point
Copy the full SHA ee14a96View commit details -
fs: fix to not return for void function
PR-URL: nodejs#50769 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Jungku Lee authored and Lei Shi committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 5b17fc9 - Browse repository at this point
Copy the full SHA 5b17fc9View commit details -
deps: update zlib to 1.2.13.1-motley-5daffc7
PR-URL: nodejs#50803 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0b110cc - Browse repository at this point
Copy the full SHA 0b110ccView commit details -
doc: update email to reflect affiliation
PR-URL: nodejs#50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Configuration menu - View commit details
-
Copy full SHA for 33009c7 - Browse repository at this point
Copy the full SHA 33009c7View commit details -
v8,tools: expose necessary V8 defines
PR-URL: nodejs#50820 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c185b8d - Browse repository at this point
Copy the full SHA c185b8dView commit details -
doc: add a section regarding
instanceof
inprimordials.md
PR-URL: nodejs#50874 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 03d5eff - Browse repository at this point
Copy the full SHA 03d5effView commit details -
meta: clarify recommendation for bug reproductions
Sometimes reporters link to a repo for their repro, which not only likely takes them more time to setup, but also is less convenient for maintainers. Setting up a repo goes against the idea of a minimal repro, as if it was actually minimal, they would not have bothered creating a repo. PR-URL: nodejs#50882 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Configuration menu - View commit details
-
Copy full SHA for 31bd119 - Browse repository at this point
Copy the full SHA 31bd119View commit details -
src: assert return value of BN_bn2binpad
Every other invocation of BN_bn2binpad checks the return value. For safety and consistency, do so in RandomPrimeTraits::EncodeOutput() as well. PR-URL: nodejs#50860 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a24623e - Browse repository at this point
Copy the full SHA a24623eView commit details -
fs: fix glob returning duplicates
PR-URL: nodejs#50881 Fixes: nodejs#50875 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9c4813 - Browse repository at this point
Copy the full SHA e9c4813View commit details -
benchmark: update iterations in benchmark/util/splice-one.js
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: nodejs#50571 PR-URL: nodejs#50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Configuration menu - View commit details
-
Copy full SHA for 6d2e379 - Browse repository at this point
Copy the full SHA 6d2e379View commit details -
meta: clarify nomination process according to Node.js charter
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#50834 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Configuration menu - View commit details
-
Copy full SHA for 810905c - Browse repository at this point
Copy the full SHA 810905cView commit details -
fs: improve error performance for
rmdirSync
PR-URL: nodejs#49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Configuration menu - View commit details
-
Copy full SHA for 31e837c - Browse repository at this point
Copy the full SHA 31e837cView commit details -
fs: add c++ fast path for writeFileSync utf8
PR-URL: nodejs#49884 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a59ff19 - Browse repository at this point
Copy the full SHA a59ff19View commit details