Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: increase iteration number to appropriate one #50861

Closed
wants to merge 79 commits into from

Commits on Nov 23, 2023

  1. benchmark: increase iteration number to appropriate one

    Increase the iteration number from 500 to 2500 to make time consumption
    of crypto operation dominate the benchmark running.
    
    Fixes: nodejs#50571
    Lei Shi committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4207129 View commit details
    Browse the repository at this point in the history
  2. benchmark: increase get-ciphers iteration number to appropriate one

    Increase the iteration number from 5000 to 500000 to make time
    consumption of crypto operation dominate the benchmark running.
    
    Fixes: nodejs#50571
    Lei Shi committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d99642a View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. build: disable flag v8_scriptormodule_legacy_lifetime

    Usages of `v8::ScriptOrModule` were removed in nodejs#44198
    so the flag can be disabled by default.
    
    PR-URL: nodejs#50616
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    legendecas authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    186fe2c View commit details
    Browse the repository at this point in the history
  2. permission: mark const functions as such

    Otherwise, non-mutating functions such as is_tree_granted unnecessarily
    require pointers to mutable data structures.
    
    PR-URL: nodejs#50705
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    tniessen authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    366d727 View commit details
    Browse the repository at this point in the history
  3. doc: update print results(detail) in PerformanceEntry

    PR-URL: nodejs#50723
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Jungku Lee authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    eecb717 View commit details
    Browse the repository at this point in the history
  4. test: give more time to GC in test-shadow-realm-gc-*

    When --node-builtin-modules-path is used, we read and create
    new strings for builtins in each realm which increases the memory
    usage. As a result GC may not be able to keep up with the
    allocation done in the loop in the test.
    
    As a workaround, give GC a bit more time by waiting for a timer
    in the loop.
    
    PR-URL: nodejs#50735
    Refs: nodejs#50726
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    joyeecheung authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    377c28d View commit details
    Browse the repository at this point in the history
  5. test: mark SEA tests as flaky on PowerPC

    PR-URL: nodejs#50750
    Refs: nodejs#50740
    Refs: nodejs/reliability#718
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    joyeecheung authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1108a98 View commit details
    Browse the repository at this point in the history
  6. build: fix GN configuration for deps/base64

    PR-URL: nodejs#50696
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    zcbenz authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9cb0148 View commit details
    Browse the repository at this point in the history
  7. test: skip parallel/test-macos-app-sandbox if disk space < 120MB

    It needs to copy the Node.js binary which is currently almost
    100MB. To be safe, skip the test when the available disk space
    is smaller than 120MB.
    
    PR-URL: nodejs#50764
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    joyeecheung authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c4032f2 View commit details
    Browse the repository at this point in the history
  8. test: improve test-bootstrap-modules.js

    Divide builtins into two lists depending on whether
    they are loaded before pre-execution or at run time,
    and give clearer suggestions about how to deal with them
    based on the category they are in.
    
    This helps preventing regressions like the one reported
    in nodejs#45662.
    
    PR-URL: nodejs#50708
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1e72c91 View commit details
    Browse the repository at this point in the history
  9. perf_hooks: implement performance.now() with fast API calls

    PR-URL: nodejs#50492
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    joyeecheung authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dfde215 View commit details
    Browse the repository at this point in the history
  10. benchmark: rewrite import.meta benchmark

    This is a ESM benchmark, rewrite it so that we are directly
    benchmarking the ESM import.meta paths and using number of
    loads for op/s calculation, instead of doing it in startup
    benchmarks and nesting number of process/workers spawn
    for op/s calculation.
    
    PR-URL: nodejs#50683
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    joyeecheung authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6db3c64 View commit details
    Browse the repository at this point in the history
  11. deps: update simdutf to 4.0.4

    PR-URL: nodejs#50772
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6304f7c View commit details
    Browse the repository at this point in the history
  12. doc: fix fs.writeFileSync return value documentation

    In nodejs#50009, the return value was accidentally made part of `flush` option bullet point.
    
    PR-URL: nodejs#50760
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    RyanZim authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e83baa6 View commit details
    Browse the repository at this point in the history
  13. test: replace forEach() with for-loop

    PR-URL: nodejs#50596
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jabro86 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0169a09 View commit details
    Browse the repository at this point in the history
  14. benchmark: increase the iteration number to an appropriate value

    Current iteration number is too small that fwrite occupies large
    portion of execution time which made crypo execution time measured
    inaccurate. The iteration above 1e5 makes 50% higher and stable
    score.
    
    PR-URL: nodejs#50766
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a9fa824 View commit details
    Browse the repository at this point in the history
  15. stream: add Symbol.toStringTag to Compression Streams

    PR-URL: nodejs#50712
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    panva authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    426ca12 View commit details
    Browse the repository at this point in the history
  16. stream: yield expected Error class on zlib errors

    PR-URL: nodejs#50712
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    panva authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d899d5e View commit details
    Browse the repository at this point in the history
  17. test: update WPT files for WebIDL tests

    PR-URL: nodejs#50712
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    panva authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cbdf5a6 View commit details
    Browse the repository at this point in the history
  18. src: remove erroneous default argument in RadixTree

    This default argument can never benefit any potential caller because any
    call site that occurs after this definition will result in a compiler
    error due to RadixTree::Lookup(const std::string_view&) now being an
    ambiguous call target.
    
    PR-URL: nodejs#50736
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4831f25 View commit details
    Browse the repository at this point in the history
  19. src: avoid copying strings in FSPermission::Apply

    The use of string_view and subsequent copying to a string was supposed
    to be a minor optimization in 640a7918, however, since 413c16e, no
    string splitting occurs anymore. Therefore, we can simply pass around
    some references instead of using string_view or copying strings.
    
    Refs: nodejs#48491
    Refs: nodejs#49047
    PR-URL: nodejs#50662
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c801888 View commit details
    Browse the repository at this point in the history
  20. test: replace forEach in whatwg-encoding-custom-interop

    PR-URL: nodejs#50607
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    HonzaMac authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    30415df View commit details
    Browse the repository at this point in the history
  21. src: iterate on import attributes array correctly

    The array's length is supposed to be a multiple of two for dynamic
    import callbacks.
    
    Fixes: nodejs#50700
    PR-URL: nodejs#50703
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    be26f4d View commit details
    Browse the repository at this point in the history
  22. inspector: use private fields instead of symbols

    PR-URL: nodejs#50776
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    anonrig authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a1cb897 View commit details
    Browse the repository at this point in the history
  23. build: add configuration flag to enable Maglev

    This adds a configuration flag to enable V8's Maglev compiler.
    
    Unfortunately compilation fails unless you have clang-14+ or gcc-13+,
    but I sent a patch for that upstream. Other than that, it builds and all
    tests pass locally on my x86-64 Linux machine.
    
    The gn scraper regexes were broken preventing the compilation from
    linking. Fix them. As a drive-by, also add additional conditionals for
    compilation on 32-bit arm.
    
    Refs: nodejs#50690
    PR-URL: nodejs#50692
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    kvakil authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a5cafc5 View commit details
    Browse the repository at this point in the history
  24. test: enable idlharness tests for encoding

    TextDecoderStream and TextEncoderStream are now exposed as globals,
    so we can run the entire Encoding idlharness test suite.
    
    PR-URL: nodejs#50778
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MattiasBuelens authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3384dfd View commit details
    Browse the repository at this point in the history
  25. doc: update Crypto API doc for x509.keyUsage

    PR-URL: nodejs#50603
    Refs: nodejs#48727
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    DMeechan authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8eafec3 View commit details
    Browse the repository at this point in the history
  26. deps: V8: cherry-pick 475c8cdf9a95

    Original commit message:
    
        [ptr-compr] Fix multi-cage mode
    
        This CL introduces PtrComprCageAccessScope which sets/restores current
        thread's pointer compression cage base values. It's supposed to be used
        by V8 jobs accessing V8 heap outside of v8::Isolate::Scope or
        i::LocalHeap or i::LocalIsolate scopes (they already ensure that the
        cage base values are properly initialized).
        For all other build modes PtrComprCageAccessScope is a no-op.
    
        For simplicity reasons the multi-cage mode is made incompatible with
        external code space.
    
        Bug: v8:13788, v8:14292
        Change-Id: I06c2d19a1eb7254fa7af07a17617e22d98abea9f
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846592
        Reviewed-by: Jakob Linke <jgruber@chromium.org>
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Igor Sheludko <ishell@chromium.org>
        Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#90075}
    
    Refs: v8/v8@475c8cd
    PR-URL: nodejs#50680
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14292
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    kvakil authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e91566f View commit details
    Browse the repository at this point in the history
  27. src: add IsolateScopes before using isolates

    The V8 API requires entering an isolate before using it. We were often
    not doing this, which worked fine in practice. However when (multi-cage)
    pointer compression is enabled, the correct isolate needs to be active
    in order to decompress pointers correctly, otherwise it causes crashes.
    
    Fix this by sprinkling in some calls to v8::Isolate::Scope::Scope where
    they were missing.
    
    This also introduces RAIIIsolateWithoutEntering which is used in
    JSONParser to avoid otherwise exposing the Isolate::Scope outside of the
    class.
    
    Tested by compiling with `--experimental-enable-pointer-compression`
    locally and running all tests.
    
    Refs: nodejs/build#3204 (comment)
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14292
    PR-URL: nodejs#50680
    Refs: v8/v8@475c8cd
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    kvakil authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f4da4ab View commit details
    Browse the repository at this point in the history
  28. test: use ppc and ppc64 to skip SEA tests on PowerPC

    It seems using ppc alone is not enough. Add ppc64 to be safe.
    
    PR-URL: nodejs#50828
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me>
    joyeecheung authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7131119 View commit details
    Browse the repository at this point in the history
  29. deps: update minimatch to 9.0.3

    PR-URL: nodejs#50806
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    696bfc4 View commit details
    Browse the repository at this point in the history
  30. tools: update lint-md-dependencies to rollup@4.5.0

    PR-URL: nodejs#50807
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f236e17 View commit details
    Browse the repository at this point in the history
  31. tools: update eslint to 8.54.0

    PR-URL: nodejs#50809
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f947592 View commit details
    Browse the repository at this point in the history
  32. test: use requires instead of flaky in console WPT status

    PR-URL: nodejs#50812
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    panva authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    478d646 View commit details
    Browse the repository at this point in the history
  33. deps: update undici to 5.27.2

    PR-URL: nodejs#50813
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d6a85d2 View commit details
    Browse the repository at this point in the history
  34. net: check pipe mode and path

    PR-URL: nodejs#50770
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    theanarkh authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8735574 View commit details
    Browse the repository at this point in the history
  35. test: replace forEach() with for ... of in test-tls-getprotocol.js

    PR-URL: nodejs#50600
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    SociableSteve authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    46c6e06 View commit details
    Browse the repository at this point in the history
  36. test: replace forEach with for-of in test-url-relative

    PR-URL: nodejs#50788
    Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    vitosorriso authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ecc8936 View commit details
    Browse the repository at this point in the history
  37. stream: fix enumerability of ReadableStream.prototype.values

    PR-URL: nodejs#50779
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MattiasBuelens authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5fc7bed View commit details
    Browse the repository at this point in the history
  38. stream: fix enumerability of ReadableStream.from

    PR-URL: nodejs#50779
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MattiasBuelens authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9266d1c View commit details
    Browse the repository at this point in the history
  39. test: add note about readable streams with type owning

    PR-URL: nodejs#50779
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MattiasBuelens authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c21e806 View commit details
    Browse the repository at this point in the history
  40. test: add note about unresolved spec issue

    PR-URL: nodejs#50779
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MattiasBuelens authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    042ea75 View commit details
    Browse the repository at this point in the history
  41. deps: update ada to 2.7.4

    PR-URL: nodejs#50815
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7793773 View commit details
    Browse the repository at this point in the history
  42. src: add --disable-warning option

    Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    PR-URL: nodejs#50661
    Fixes: nodejs#30810
    Fixes: nodejs#47478
    Fixes: nodejs#46862
    Fixes: nodejs#40940
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    3 people authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    61234ce View commit details
    Browse the repository at this point in the history
  43. crypto: update root certificates to NSS 3.95

    This is the certdata.txt[0] from NSS 3.95, released on 2023-11-16.
    
    This is the version of NSS that will ship in Firefox 121 on
    2023-12-19.
    
    Certificates added:
    - TrustAsia Global Root CA G3
    - TrustAsia Global Root CA G4
    - CommScope Public Trust ECC Root-01
    - CommScope Public Trust ECC Root-02
    - CommScope Public Trust RSA Root-01
    - CommScope Public Trust RSA Root-02
    
    Certificates removed:
    - Autoridad de Certificacion Firmaprofesional CIF A62634068
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_95_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: nodejs#50805
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9d9c9b4 View commit details
    Browse the repository at this point in the history
  44. dns: call handle.setServers() with a valid array

    `handle.setServers()` takes an array, not a string.
    
    PR-URL: nodejs#50811
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    lpinca authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9af0fb0 View commit details
    Browse the repository at this point in the history
  45. deps: update icu to 74.1

    PR-URL: nodejs#50515
    Reviewed-By: Steven R Loomis <srl295@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    354eb49 View commit details
    Browse the repository at this point in the history
  46. build: add GN configurations for simdjson

    PR-URL: nodejs#50831
    Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    zcbenz authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a653bde View commit details
    Browse the repository at this point in the history
  47. doc: fix typos in --allow-fs-*

    Refs: nodejs#49047
    PR-URL: nodejs#50845
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    tniessen authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    802c11d View commit details
    Browse the repository at this point in the history
  48. doc: add CanadaHonk to triagers

    PR-URL: nodejs#50848
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    CanadaHonk authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3c46275 View commit details
    Browse the repository at this point in the history
  49. 2023-11-22, Version 20.10.0 'Iron' (LTS)

    Notable changes:
    
    deps:
      * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908
    doc:
      * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217
    esm:
      * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096
      * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140
      * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869
    fs:
      * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095
      * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009
    lib:
      * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830
    stream:
      * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187
      * call helper function from push and unshift (Raz Luvaton) nodejs#50173
      * optimize Writable (Robert Nagy) nodejs#50012
    test_runner, cli:
      * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996
    vm:
      * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141
      * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950
    wasi:
    
    PR-URL: nodejs#50682
    targos authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e36ce82 View commit details
    Browse the repository at this point in the history
  50. src: fix compatility with upcoming V8 12.1 APIs

    PR-URL: nodejs#50709
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    zcbenz authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0ad7229 View commit details
    Browse the repository at this point in the history
  51. tools: use macOS keychain to notarize the releases

    PR-URL: nodejs#50715
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    UlisesGascon authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    73e71ed View commit details
    Browse the repository at this point in the history
  52. doc: create deprecation code for isWebAssemblyCompiledModule

    PR-URL: nodejs#50486
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    marco-ippolito authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    38f3754 View commit details
    Browse the repository at this point in the history
  53. permission: do not create symlinks if target is relative

    The permission model's security guarantees fall apart in the presence of
    relative symbolic links. When an application attempts to create a
    relative symlink, the permission model currently resolves the relative
    path into an absolute path based on the process's current working
    directory, checks whether the process has the relevant permissions, and
    then creates the symlink using the absolute target path. This behavior
    is plainly incorrect for two reasons:
    
    1. The target path should never be resolved relative to the current
       working directory. If anything, it should be resolved relative to the
       symlink's location. (Of course, there is one insane exception to this
       rule: on Windows, each process has a current working directory per
       drive, and symlinks can be created with a target path relative to the
       current working directory of a specific drive. In that case, the
       relative path will be resolved relative to the current working
       directory for the respective drive, and the symlink will be created
       on disk with the resulting absolute path. Other relative symlinks
       will be stored as-is.)
    2. Silently creating an absolute symlink when the user requested a
       relative symlink is wrong. The user may (or may not) rely on the
       symlink being relative. For example, npm heavily relies on relative
       symbolic links such that node_modules directories can be moved around
       without breaking.
    
    Because we don't know the user's intentions, we don't know if creating
    an absolute symlink instead of a relative symlink is acceptable. This
    patch prevents the faulty behavior by not (incorrectly) resolving
    relative symlink targets when the permission model is enabled, and by
    instead simply refusing the create any relative symlinks.
    
    The fs APIs accept Uint8Array objects for paths to be able to handle
    arbitrary file name charsets, however, checking whether such an object
    represents a relative part in a reliable and portable manner is tricky.
    Other parts of the permission model incorrectly convert such objects to
    strings and then back to an Uint8Array (see 1f64147),
    however, for now, this bug fix will simply throw on non-string symlink
    targets when the permission model is enabled. (The permission model
    already breaks existing applications in various ways, so this shouldn't
    be too dramatic.)
    
    PR-URL: nodejs#49156
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2d550a2 View commit details
    Browse the repository at this point in the history
  54. doc: get rid of unnecessary eslint-skip comments

    PR-URL: nodejs#50829
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    aduh95 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    19ac425 View commit details
    Browse the repository at this point in the history
  55. fs: improve error perf of sync lstat+fstat

    PR-URL: nodejs#49868
    Refs: nodejs/performance#106
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    CanadaHonk authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    154b8de View commit details
    Browse the repository at this point in the history
  56. doc: shard not supported with watch mode

    PR-URL: nodejs#50640
    Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    pulkit-30 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f2d4b88 View commit details
    Browse the repository at this point in the history
  57. test: replace foreach with for in test-https-simple.js

    Fixes: nodejs#50818
    PR-URL: nodejs#49793
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
    Shikha Mehta authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4a3ce61 View commit details
    Browse the repository at this point in the history
  58. tools: add macOS notarization verification step

    PR-URL: nodejs#50833
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    UlisesGascon authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8b61c75 View commit details
    Browse the repository at this point in the history
  59. fs: replace deprecated path._makeLong in copyFile

    PR-URL: nodejs#50844
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    CanadaHonk authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ccd5bee View commit details
    Browse the repository at this point in the history
  60. deps: V8: cherry-pick 0f9ebbc672c7

    Original commit message:
    
        [flags] Remove --harmony-string-is-well-formed
    
        The String.prototype.isWellFormed and toWellFormed have shipped
        since M111.
    
        Bug: v8:13557
        Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
        Reviewed-by: Shu-yu Guo <syg@chromium.org>
        Commit-Queue: Chengzhong Wu (legendecas) <legendecas@gmail.com>
        Cr-Commit-Position: refs/heads/main@{#90398}
    
    Refs: v8/v8@0f9ebbc
    PR-URL: nodejs#50867
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    legendecas authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4e92c1c View commit details
    Browse the repository at this point in the history
  61. test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

    PR-URL: nodejs#50795
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    StiffWriter00 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    247915b View commit details
    Browse the repository at this point in the history
  62. test: replace forEach with for of

    PR-URL: nodejs#50594
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RBrNx authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6d4439a View commit details
    Browse the repository at this point in the history
  63. test: fix dns test case failures after c-ares update to 1.21.0+

    c-ares has made intentional changes to the behavior of TXT records
    to comply with RFC 7208, which concatenates multiple strings for
    the same TXT record into a single string.  Multiple TXT records
    are not concatenated.
    
    Also, response handling has changed, such that a response which is
    completely invalid in formatting is thrown away as a malicious
    forged/spoofed packet rather than returning EBADRESP.  This is one
    step toward RFC 9018 (EDNS COOKIES) which will require the message
    to at least be structurally valid to validate against spoofed
    records.
    
    Fix By: Brad House (@bradh352)
    
    PR-URL: nodejs#50743
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Fixes: nodejs#50741
    Refs: nodejs#50444
    bradh352 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5ecfb5c View commit details
    Browse the repository at this point in the history
  64. meta: move cjihrig to TSC regular member

    PR-URL: nodejs#50816
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    cjihrig authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    75a76a4 View commit details
    Browse the repository at this point in the history
  65. src: fix coverity warning

    - reduce copying by using std::move
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: nodejs#50846
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ee14a96 View commit details
    Browse the repository at this point in the history
  66. fs: fix to not return for void function

    PR-URL: nodejs#50769
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Jungku Lee authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5b17fc9 View commit details
    Browse the repository at this point in the history
  67. deps: update zlib to 1.2.13.1-motley-5daffc7

    PR-URL: nodejs#50803
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0b110cc View commit details
    Browse the repository at this point in the history
  68. doc: update email to reflect affiliation

    PR-URL: nodejs#50856
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    anonrig authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    33009c7 View commit details
    Browse the repository at this point in the history
  69. v8,tools: expose necessary V8 defines

    PR-URL: nodejs#50820
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    zcbenz authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c185b8d View commit details
    Browse the repository at this point in the history
  70. doc: add a section regarding instanceof in primordials.md

    PR-URL: nodejs#50874
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    aduh95 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    03d5eff View commit details
    Browse the repository at this point in the history
  71. meta: clarify recommendation for bug reproductions

    Sometimes reporters link to a repo for their repro, which
    not only likely takes them more time to setup, but also is less
    convenient for maintainers. Setting up a repo goes against the idea of a
    minimal repro, as if it was actually minimal, they would not have
    bothered creating a repo.
    
    PR-URL: nodejs#50882
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    aduh95 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    31bd119 View commit details
    Browse the repository at this point in the history
  72. src: assert return value of BN_bn2binpad

    Every other invocation of BN_bn2binpad checks the return value. For
    safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
    as well.
    
    PR-URL: nodejs#50860
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a24623e View commit details
    Browse the repository at this point in the history
  73. fs: fix glob returning duplicates

    PR-URL: nodejs#50881
    Fixes: nodejs#50875
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e9c4813 View commit details
    Browse the repository at this point in the history
  74. benchmark: update iterations in benchmark/util/splice-one.js

    Increase the number of iterations from 1e5 to 5e6
    to avoid the test performance gap caused by inactive
    V8 optimization caused by insufficient number of iterations
    
    Refs: nodejs#50571
    PR-URL: nodejs#50698
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Septa2112 authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6d2e379 View commit details
    Browse the repository at this point in the history
  75. meta: clarify nomination process according to Node.js charter

    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    PR-URL: nodejs#50834
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    mcollina authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    810905c View commit details
    Browse the repository at this point in the history
  76. fs: improve error performance for rmdirSync

    PR-URL: nodejs#49846
    Refs: nodejs/performance#106
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    CanadaHonk authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    31e837c View commit details
    Browse the repository at this point in the history
  77. fs: add c++ fast path for writeFileSync utf8

    PR-URL: nodejs#49884
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    CanadaHonk authored and Lei Shi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a59ff19 View commit details
    Browse the repository at this point in the history