fs: add flush option to appendFile() functions by cjihrig · Pull Request #50095 · nodejs/node

cjihrig · 2023-10-08T23:27:56Z

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in #50009, but this makes it more official.

Refs: #49886
Refs: #50009

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in nodejs#50009, but this makes it more official. Refs: nodejs#49886 Refs: nodejs#50009

mcollina

lgtm

nodejs-github-bot · 2023-10-11T19:40:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54718/

nodejs-github-bot · 2023-10-16T21:23:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54861/

nodejs-github-bot · 2023-10-16T23:05:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54863/

nodejs-github-bot · 2023-10-17T01:35:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54865/

nodejs-github-bot · 2023-10-17T12:21:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54878/

nodejs-github-bot · 2023-10-17T12:45:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54881/

nodejs-github-bot · 2023-10-17T13:02:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54882/

nodejs-github-bot · 2023-10-17T13:15:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54883/

richardlau · 2023-10-17T14:06:06Z

CI's are failing test-runner-cli-concurrency.js -- this test was rewritten by #50108. You should not need to rebase this PR to pick up this change but you will need to start a new CI (not resume as that will continually try to run the tests on the commit from before) so that the PR is rebased onto current main.

I'll add the label to request a new CI run.

nodejs-github-bot · 2023-10-17T14:09:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54886/

nodejs-github-bot · 2023-10-17T16:47:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54889/

nodejs-github-bot · 2023-10-17T20:20:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54903/

nodejs-github-bot · 2023-10-18T01:35:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54915/ 🟢

nodejs-github-bot · 2023-10-18T01:51:42Z

Landed in f971106

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in #50009, but this makes it more official. Refs: #49886 Refs: #50009 PR-URL: #50095 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos · 2023-10-23T09:20:51Z

Please think about assigning the semver-minor label when you add new features.

Notable changes: doc: * add H4ad to collaborators (Vinícius Lourenço) #50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095 lib: * (SEMVER-MINOR) add `navigator.userAgent` (Yagiz Nizipli) #50200 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187 * call helper function from push and unshift (Raz Luvaton) #50173 PR-URL: #50335

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in nodejs#50009, but this makes it more official. Refs: nodejs#49886 Refs: nodejs#50009 PR-URL: nodejs#50095 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: doc: * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095 lib: * (SEMVER-MINOR) add `navigator.userAgent` (Yagiz Nizipli) nodejs#50200 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187 * call helper function from push and unshift (Raz Luvaton) nodejs#50173 PR-URL: nodejs#50335

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in #50009, but this makes it more official. Refs: #49886 Refs: #50009 PR-URL: #50095 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 doc: * add H4ad to collaborators (Vinícius Lourenço) #50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096 * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095 * add flush option to writeFile() functions (Colin Ihrig) #50009 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187 * call helper function from push and unshift (Raz Luvaton) #50173 * optimize Writable (Robert Nagy) #50012 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 wasi: PR-URL: #50682

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908 doc: * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096 * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095 * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187 * call helper function from push and unshift (Raz Luvaton) nodejs#50173 * optimize Writable (Robert Nagy) nodejs#50012 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141 * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950 wasi: PR-URL: nodejs#50682

cjihrig requested a review from mcollina October 8, 2023 23:27

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 8, 2023

fs: add flush option to appendFile() functions

9a8cc22

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in nodejs#50009, but this makes it more official. Refs: nodejs#49886 Refs: nodejs#50009

cjihrig force-pushed the append-file branch from 975ee1e to 9a8cc22 Compare October 8, 2023 23:28

mcollina approved these changes Oct 9, 2023

View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023

cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Oct 18, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023

nodejs-github-bot merged commit f971106 into nodejs:main Oct 18, 2023

cjihrig deleted the append-file branch October 18, 2023 01:51

github-actions bot mentioned this pull request Oct 19, 2023

CI Reliability 2023-10-19 nodejs/reliability#691

Open

25 tasks

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 23, 2023

targos mentioned this pull request Oct 23, 2023

v21.1.0 release proposal #50335

Merged

targos mentioned this pull request Nov 12, 2023

v20.10.0 release proposal #50682

Merged

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

Uh oh!

Conversation

cjihrig commented Oct 8, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 11, 2023

Uh oh!

nodejs-github-bot commented Oct 16, 2023

Uh oh!

nodejs-github-bot commented Oct 16, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

richardlau commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 18, 2023 • edited by cjihrig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 18, 2023

Uh oh!

targos commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nodejs-github-bot commented Oct 18, 2023 •

edited by cjihrig

Loading