meta: clarify nomination process according to Node.js charter #50834

mcollina · 2023-11-21T08:59:46Z

Clarification on the nomination process as mentioned by @jasnell in nodejs/TSC#1467 (comment).

Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2023-11-21T08:59:50Z

Review requested:

@nodejs/tsc

GOVERNANCE.md

Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com>

GeoffreyBooth · 2023-11-21T12:51:37Z

I don't see how that comment led to this. And this language feels harsh; mentioning directly that the TSC might overrule an objection feels like it would chill people making objections. Doesn't the TSC already have this power without needing to add this text?

mcollina · 2023-11-21T12:57:53Z

Yes. Apparently a few other TSC members think it is required to explicit it out.

GOVERNANCE.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>

mhdawson

LGTM

GOVERNANCE.md

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

jasnell · 2023-11-24T14:29:55Z

GOVERNANCE.md

-the nomination fails.
+The nomination passes if no collaborators oppose it after one week. In the case
+of an objection, the TSC is responsible for working with the individuals
+involved and finding a resolution.


Suggested change

involved and finding a resolution.

involved and finding a resolution. The TSC may, at its discretion, vote to override

any objection but should do so only after other measures to reach consensus have

failed.

I prefer the existing phrasing since it says the TSC is responsible for resolving the matter rather than just voting. The TSC for example can come to consensus about overriding a nomination without voting. It also emphasizes the TSC working with the individuals rather than them having to reach consensus on their own.

jasnell

One suggestion, consider it optional. Otherwise LGTM

nodejs-github-bot · 2023-11-25T16:00:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55916/

nodejs-github-bot · 2023-11-25T20:19:26Z

Commit Queue failed

- Loading data for nodejs/node/pull/50834 ✔ Done loading data for nodejs/node/pull/50834 ----------------------------------- PR info ------------------------------------ Title meta: clarify nomination process according to Node.js charter (#50834) Author Matteo Collina (@mcollina) Branch mcollina:clarify-nomination-process -> nodejs:main Labels meta Commits 4 - meta: clarify nomination process according to Node.js charter - Update GOVERNANCE.md - Update GOVERNANCE.md - Update GOVERNANCE.md Committers 2 - Matteo Collina - GitHub PR-URL: https://github.com/nodejs/node/pull/50834 Reviewed-By: Gireesh Punathil Reviewed-By: Rafael Gonzaga Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: Joyee Cheung Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: James M Snell Reviewed-By: Ruy Adorno ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50834 Reviewed-By: Gireesh Punathil Reviewed-By: Rafael Gonzaga Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: Joyee Cheung Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: James M Snell Reviewed-By: Ruy Adorno -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 21 Nov 2023 08:59:46 GMT ✔ Approvals: 14 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1741455492 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742081465 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742112546 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742210875 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742213614 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742224874 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742622759 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742635069 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743060178 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743672722 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743943202 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743957631 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748043163 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748302024 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50834 From https://github.com/nodejs/node * branch refs/pull/50834/merge -> FETCH_HEAD ✔ Fetched commits as ed5cb37ccbc4..ea35554c7d75 -------------------------------------------------------------------------------- [main af5b57919e] meta: clarify nomination process according to Node.js charter Author: Matteo Collina Date: Tue Nov 21 09:59:10 2023 +0100 1 file changed, 3 insertions(+) [main f41d89451f] Update GOVERNANCE.md Author: Matteo Collina Date: Tue Nov 21 10:13:59 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main b03aacd5a2] Update GOVERNANCE.md Author: Matteo Collina Date: Tue Nov 21 15:42:33 2023 +0100 1 file changed, 3 insertions(+), 5 deletions(-) [main 6d64197199] Update GOVERNANCE.md Author: Matteo Collina Date: Wed Nov 22 10:35:08 2023 +0100 1 file changed, 3 insertions(+), 3 deletions(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
meta: clarify nomination process according to Node.js charter

Signed-off-by: Matteo Collina hello@matteocollina.com
PR-URL: #50834
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Ruy Adorno ruyadorno@google.com

[detached HEAD 34119b1e9a] meta: clarify nomination process according to Node.js charter
Author: Matteo Collina hello@matteocollina.com
Date: Tue Nov 21 09:59:10 2023 +0100
1 file changed, 3 insertions(+)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update GOVERNANCE.md

Co-authored-by: Gireesh Punathil gpunathi@in.ibm.com
PR-URL: #50834
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Ruy Adorno ruyadorno@google.com

[detached HEAD 676df9d944] Update GOVERNANCE.md
Author: Matteo Collina matteo.collina@gmail.com
Date: Tue Nov 21 10:13:59 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update GOVERNANCE.md

Co-authored-by: Michael Dawson mdawson@devrus.com
PR-URL: #50834
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Ruy Adorno ruyadorno@google.com

[detached HEAD 07dc7aa427] Update GOVERNANCE.md
Author: Matteo Collina matteo.collina@gmail.com
Date: Tue Nov 21 15:42:33 2023 +0100
1 file changed, 3 insertions(+), 5 deletions(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update GOVERNANCE.md

Co-authored-by: Antoine du Hamel duhamelantoine1995@gmail.com
PR-URL: #50834
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Ruy Adorno ruyadorno@google.com

[detached HEAD 1a972e305a] Update GOVERNANCE.md
Author: Matteo Collina matteo.collina@gmail.com
Date: Wed Nov 22 10:35:08 2023 +0100
1 file changed, 3 insertions(+), 3 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6991191399

nodejs-github-bot · 2023-11-26T17:14:21Z

Landed in 5f8ec99

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#50834 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #50834 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>

meta: clarify nomination process according to Node.js charter

a023014

Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 21, 2023

mcollina requested review from jasnell and mhdawson November 21, 2023 09:00

gireeshpunathil approved these changes Nov 21, 2023

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

Update GOVERNANCE.md

97acd78

Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com>

RafaelGSS approved these changes Nov 21, 2023

View reviewed changes

ronag approved these changes Nov 21, 2023

View reviewed changes

mhdawson reviewed Nov 21, 2023

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

Update GOVERNANCE.md

565d236

Co-authored-by: Michael Dawson <mdawson@devrus.com>

anonrig approved these changes Nov 21, 2023

View reviewed changes

aduh95 approved these changes Nov 21, 2023

View reviewed changes

mhdawson approved these changes Nov 21, 2023

View reviewed changes

joyeecheung approved these changes Nov 21, 2023

View reviewed changes

benjamingr approved these changes Nov 21, 2023

View reviewed changes

lpinca approved these changes Nov 21, 2023

View reviewed changes

RaisinTen approved these changes Nov 22, 2023

View reviewed changes

aduh95 reviewed Nov 22, 2023

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

Update GOVERNANCE.md

ea35554

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos approved these changes Nov 22, 2023

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023

legendecas approved these changes Nov 22, 2023

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023

This comment was marked as off-topic.

Sign in to view

jasnell reviewed Nov 24, 2023

View reviewed changes

jasnell approved these changes Nov 24, 2023

View reviewed changes

ruyadorno approved these changes Nov 24, 2023

View reviewed changes

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 25, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023

nodejs-github-bot merged commit 5f8ec99 into nodejs:main Nov 26, 2023
56 checks passed

RafaelGSS mentioned this pull request Nov 28, 2023

v21.3.0 proposal #50954

Merged

UlisesGascon mentioned this pull request Dec 12, 2023

v20.11.0 proposal #51124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: clarify nomination process according to Node.js charter #50834

meta: clarify nomination process according to Node.js charter #50834

mcollina commented Nov 21, 2023 •

edited

Loading

nodejs-github-bot commented Nov 21, 2023

GeoffreyBooth commented Nov 21, 2023

mcollina commented Nov 21, 2023

mhdawson left a comment

This comment was marked as off-topic.

jasnell Nov 24, 2023

benjamingr Nov 24, 2023

jasnell left a comment

nodejs-github-bot commented Nov 25, 2023

nodejs-github-bot commented Nov 25, 2023

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Nov 26, 2023

-involved and finding a resolution.
+involved and finding a resolution. The TSC may, at its discretion, vote to override
+any objection but should do so only after other measures to reach consensus have
+failed.

meta: clarify nomination process according to Node.js charter #50834

meta: clarify nomination process according to Node.js charter #50834

Conversation

mcollina commented Nov 21, 2023 • edited Loading

nodejs-github-bot commented Nov 21, 2023

GeoffreyBooth commented Nov 21, 2023

mcollina commented Nov 21, 2023

mhdawson left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

jasnell Nov 24, 2023

Choose a reason for hiding this comment

benjamingr Nov 24, 2023

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 25, 2023

nodejs-github-bot commented Nov 25, 2023

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Nov 26, 2023

mcollina commented Nov 21, 2023 •

edited

Loading