Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve error performance for rmdirSync #49846

Merged
merged 1 commit into from
Nov 26, 2023
Merged

fs: improve error performance for rmdirSync #49846

merged 1 commit into from
Nov 26, 2023

Conversation

CanadaHonk
Copy link
Member

@CanadaHonk CanadaHonk commented Sep 25, 2023 •
edited
Loading

Results from i9/Linux/SSD:

                                                   confidence improvement accuracy (*)   (**)  (***)
fs/bench-rmdirSync.js n=10000 type='existing'                     0.54 %       ±1.35% ±1.80% ±2.34%
fs/bench-rmdirSync.js n=10000 type='non-existing'        ***     61.81 %       ±2.15% ±2.88% ±3.77%

Ref: nodejs/performance#106

Thanks to and inspiration from @anonrig 🚀

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 25, 2023
anonrig
anonrig reviewed Sep 25, 2023
View reviewed changes
lib/fs.js Outdated Show resolved Hide resolved
@anonrig anonrig mentioned this pull request Sep 25, 2023
Open
anonrig
anonrig reviewed Sep 25, 2023
View reviewed changes
benchmark/fs/bench-rmdirSync.js Outdated Show resolved Hide resolved
benchmark/fs/bench-rmdirSync.js Outdated Show resolved Hide resolved
benchmark/fs/bench-rmdirSync.js Outdated Show resolved Hide resolved
@CanadaHonk
Copy link
Member Author

Updated to fix all things mentioned in review, thanks!

@CanadaHonk CanadaHonk changed the title fs: improve performance for fs.rmdirSync fs: improve error performance for fs.rmdirSync Sep 25, 2023
@anonrig anonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. needs-benchmark-ci PR that need a benchmark CI run. labels Sep 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@CanadaHonk CanadaHonk changed the title fs: improve error performance for fs.rmdirSync fs: improve error performance for rmdirSync Sep 25, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@CanadaHonk
Copy link
Member Author

Flaky CI I think?

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@CanadaHonk
Copy link
Member Author

Flaky CI again? 😅

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54829/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54897/

@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Open
25 tasks
@CanadaHonk
Copy link
Member Author

Rebased on latest main and updated description with rebenchmark.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55773/

@CanadaHonk
Copy link
Member Author

Flaky CI?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55837/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55862/

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit f11b206 into nodejs:main Nov 26, 2023
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f11b206

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@CanadaHonk
fs: improve error performance for rmdirSync
31e837c 
PR-URL: nodejs#49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@CanadaHonk @RafaelGSS
fs: improve error performance for rmdirSync
c4f9654 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@CanadaHonk @RafaelGSS
fs: improve error performance for rmdirSync
483200f 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@CanadaHonk @RafaelGSS
fs: improve error performance for rmdirSync
d44dd9b 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@CanadaHonk @UlisesGascon
fs: improve error performance for rmdirSync
7a09209 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@CanadaHonk @UlisesGascon
fs: improve error performance for rmdirSync
cb55d04 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@CanadaHonk @UlisesGascon
fs: improve error performance for rmdirSync
0d59dda 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@CanadaHonk @UlisesGascon
fs: improve error performance for rmdirSync
f94a24c 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CanadaHonk @nodejs-github-bot @anonrig @IlyasShabi @joyeecheung @H4ad @richardlau