-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update email to reflect affiliation #50856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd need to also change the MAILMAP so your previous commit can still be attributed to you – otherwise the bot will open a PR to remove you from collaborators as soon as this is merged 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I updated |
You can validate by running $ git fetch https://github.com/nodejs/node.git main && git reset FETCH_HEAD --hard
$ git log -1 --format=%aE 4cfc188f872ba766f6e1a019165e1cd428a9f6cb
yagiz@nizipli.com
$ curl -L https://github.com/nodejs/node/pull/50856.patch | git am
$ git log -1 --format=%aE 4cfc188f872ba766f6e1a019165e1cd428a9f6cb
yagiz@nizipli.com As you can see, the mailmap is backward: it maps all the commits to your personal address, and none to your Sentry one. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Landed in 41e225c |
PR-URL: nodejs#50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: nodejs#50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: #50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: #50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: #50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: #50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: #50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: #50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
PR-URL: #50856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Updating my email address on README to reflect my affiliation with Sentry (https://sentry.io). They're sponsoring my work to Node.js starting from November 20.
cc @nodejs/tsc