`test-shadow-realm-gc-module` can crash on macOS (OOM)

[targos]

$ out/Debug/node --experimental-shadow-realm --max-old-space-size=20 /Users/mzasso/git/nodejs/node/test/parallel/test-shadow-realm-gc-module.js

<--- Last few GCs --->

[61276:0x148008000]     3114 ms: Scavenge 17.0 (20.1) -> 16.4 (25.1) MB, 1.33 / 0.00 ms  (average mu = 0.889, current mu = 0.757) allocation failure; 
[61276:0x148008000]     3147 ms: Mark-Compact 20.8 (25.8) -> 18.0 (28.6) MB, 11.12 / 0.00 ms  (+ 0.7 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 39 ms) (average mu = 0.867, current mu = 0.858) allocation fail

<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0x1026d59c8 node::DumpNativeBacktrace(__sFILE*) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 2: 0x102814ef4 node::Abort() [/Users/mzasso/git/nodejs/node/out/Debug/node]
 3: 0x1028151d8 node::ModifyCodeGenerationFromStrings(v8::Local<v8::Context>, v8::Local<v8::Value>, bool) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 4: 0x102b9f8f0 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 5: 0x1030362f8 v8::internal::Heap::stack() [/Users/mzasso/git/nodejs/node/out/Debug/node]
 6: 0x1030341d4 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/mzasso/git/nodejs/node/out/Debug/node]
...
79: 0x1042501c4 main [/Users/mzasso/git/nodejs/node/out/Debug/node]
80: 0x18157d0e0 start [/usr/lib/dyld]
[1]    61276 abort      out/Debug/node --experimental-shadow-realm --max-old-space-size=20

[MrJithil]

node:internal/process/task_queues:95
    runMicrotasks();
    ^

TypeError: Cannot import in ShadowRealm (TypeError: A dynamic import callback was not specified.)

I ran on macOS locally, above is the error message I got with Release/node

[targos]

I just tried with the release build and I get the same OOM error. I updated the title.

[targos]

/cc @legendecas who added the test in #48655

[legendecas]

I checked the last two GitHub action runs on the main branch and I didn't find this failure on the macOS build (https://github.com/nodejs/node/actions/runs/6859065494/job/18650800024 failed for a different test). And I didn't reproduce the failure with 1000 runs locally. Does this problem constantly reproduce with your local build?

Stress test: https://ci.nodejs.org/job/node-stress-single-test/464

[targos]

I am not close to my computer now but it reproduced consistently (I tried to run it between 5 and 10 times )

[MrJithil]

With the latest merge? I took the latest and now unable to reproduce

for i in {1..100}; do ./node --experimental-shadow-realm --max-old-space-size=20 test/parallel/test-shadow-realm-gc-module.js; done

[targos]

I have a arm64 Mac. Maybe it's platform specific

[MrJithil]

I am using M1 Pro chip. Is there any customisations you did like node max heap size?

[targos]

tools/test.py parallel/test-shadow-realm-gc-module --repeat 100
[00:10|% 100|+ 1|- 99]: Done

I am using M1 Pro chip. Is there any customisations you did like node max heap size?

I always build with ./configure --ninja --node-builtin-modules-path=$(pwd) in case that's relevant.

[MrJithil]

Let me check.

[marco-ippolito]

I've seen this failure in CI on different platforms, https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel8-s390x/40888/console