-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v16.8.0 release proposal #39875
v16.8.0 release proposal #39875
Commits on Aug 22, 2021
-
doc: add himadriganguly as a triager
I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that. PR-URL: #39757 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7a25bf3 - Browse repository at this point
Copy the full SHA 7a25bf3View commit details -
doc: add example of self-reference in scoped packages
PR-URL: #37630 Fixes: #37618 Refs: #37618 (comment) Co-authored-by: Michaël Zasso <targos@protonmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a387600 - Browse repository at this point
Copy the full SHA a387600View commit details -
tools: update markdown lint dependencies
PR-URL: #39770 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c34e253 - Browse repository at this point
Copy the full SHA c34e253View commit details -
doc: fix lint errors in packages.md
Code samples that use CJS-only syntax need to use the cjs markdown identifiers. PR-URL: #39792 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Configuration menu - View commit details
-
Copy full SHA for 2b02f74 - Browse repository at this point
Copy the full SHA 2b02f74View commit details -
doc: fix malformed changelog entries
PR-URL: #39791 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3041d57 - Browse repository at this point
Copy the full SHA 3041d57View commit details -
build: add option to hide console window
Adds a Environment flag to allow embedders to set CREATE_NO_WINDOW property when spawning processes, which is useful for GUI programs that do not want to show console windows when running terminal commands. PR-URL: #39712 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f284cf - Browse repository at this point
Copy the full SHA 3f284cfView commit details -
doc: deprecate using non-boolean values in the
verbatim
optionPR-URL: #38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8460a32 - Browse repository at this point
Copy the full SHA 8460a32View commit details -
doc: deprecate type coercion for
dns.lookup
optionsPR-URL: #38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2e90b10 - Browse repository at this point
Copy the full SHA 2e90b10View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7a217b - Browse repository at this point
Copy the full SHA a7a217bView commit details -
policy: canonicalize before resolving specifiers
PR-URL: #37863 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8fa3850 - Browse repository at this point
Copy the full SHA 8fa3850View commit details -
tools: update rollup to latest version in markdown linter
PR-URL: #39797 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9dc0c91 - Browse repository at this point
Copy the full SHA 9dc0c91View commit details -
meta: add gyp as owner of gyp files and tools/gyp
Co-authored-by: Jiawen Geng <technicalcute@gmail.com> PR-URL: #34847 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 158d446 - Browse repository at this point
Copy the full SHA 158d446View commit details -
src: add a constructor overload for CallbackScope
This overload accepts the current Environment* as an argument, unlike the other constructor, which accepts an Isolate*. This is useful because we can pass the current Environment* directly instead of recomputing it from the Isolate* inside the constructor. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39768 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0918ea0 - Browse repository at this point
Copy the full SHA 0918ea0View commit details -
src: call overload ctor from the original ctor
Call the new constructor overload from the original constructor to reduce code duplication. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39768 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a704c9d - Browse repository at this point
Copy the full SHA a704c9dView commit details -
tools: update markdown linter dependencies and move to ESM
PR-URL: #39801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 01093b0 - Browse repository at this point
Copy the full SHA 01093b0View commit details -
fs: combine require() and destructure
This commit combines two require() calls and subsequent destructuring operations. PR-URL: #39806 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d1900f4 - Browse repository at this point
Copy the full SHA d1900f4View commit details -
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: #39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 79079ea - Browse repository at this point
Copy the full SHA 79079eaView commit details -
Expose toUSVString so it can be used by user libraries. PR-URL: #39814 Refs: nodejs/undici#986 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6640037 - Browse repository at this point
Copy the full SHA 6640037View commit details
Commits on Aug 23, 2021
-
doc: move util.toUSVString() outside of deprecated group
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849 PR-URL: #39840 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 208305f - Browse repository at this point
Copy the full SHA 208305fView commit details -
tools: update gyp-next to v0.9.5
PR-URL: #39818 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d82ee96 - Browse repository at this point
Copy the full SHA d82ee96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8399e - Browse repository at this point
Copy the full SHA 3a8399eView commit details -
Configuration menu - View commit details
-
Copy full SHA for af7047a - Browse repository at this point
Copy the full SHA af7047aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6d50a1 - Browse repository at this point
Copy the full SHA a6d50a1View commit details -
PR-URL: #39813 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cce95c4 - Browse repository at this point
Copy the full SHA cce95c4View commit details
Commits on Aug 24, 2021
-
doc: update instructions for cc
- update intructions on adding cc for email to nodejs-sec mailing list as UI does not allow it to be done directly. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #39674 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c02165d - Browse repository at this point
Copy the full SHA c02165dView commit details -
deps: V8: cherry-pick 00bb1a77c03e
Original commit message: [date] Fix Date#getMinutes() test failures After building V8 using Clang (./out/x64.release/v8_build_config.json says that "is_clang" is true), I could reproduce the referenced bug report locally. Replacing the getMinutes() calls with getUTCMinutes() calls fixed the test failure. Signed-off-by: Darshan Sen <raisinten@gmail.com> Bug: v8:11200 Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#76367} Refs: v8/v8@00bb1a7 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39829 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a01e3ab - Browse repository at this point
Copy the full SHA a01e3abView commit details -
doc: improve description of the triagers team
PR-URL: #39833 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c50d16 - Browse repository at this point
Copy the full SHA 8c50d16View commit details -
PR-URL: #35831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c968372 - Browse repository at this point
Copy the full SHA c968372View commit details -
doc: add duplicate CVE check in sec. release doc
This commit adds a note about only creating a CVE for Node.js vulnerabilities. The motivation for this is a recent HackerOne report where I created a CVE for a c-ares issue. This CVE should have been created by the c-ares project, and it was later, but we never updated our HackerOne report to use their CVE number. Hopefully this extra note in the release doc will help us check for this situaion and avoid this in the future. PR-URL: #39845 Refs: https://hackerone.com/reports/1178337 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 254810a - Browse repository at this point
Copy the full SHA 254810aView commit details -
build: fix update authors commit
Refs: #39855 (comment) PR-URL: #39858 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 90bf247 - Browse repository at this point
Copy the full SHA 90bf247View commit details
Commits on Aug 25, 2021
-
tools: use find-inactive-collaborators to modify README.md
Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d33f897 - Browse repository at this point
Copy the full SHA d33f897View commit details -
tools: update workflow to open a pull request
Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request. PR-URL: #39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f98311a - Browse repository at this point
Copy the full SHA f98311aView commit details -
2021-08-25, Version 16.8.0 (Current)
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814 PR-URL: #39875
Configuration menu - View commit details
-
Copy full SHA for 93553dc - Browse repository at this point
Copy the full SHA 93553dcView commit details