[v16.x backport] stream: add isDisturbed helper#39819
Closed
ronag wants to merge 2 commits intonodejs:v16.x-stagingfrom
Closed
[v16.x backport] stream: add isDisturbed helper#39819ronag wants to merge 2 commits intonodejs:v16.x-stagingfrom
ronag wants to merge 2 commits intonodejs:v16.x-stagingfrom
Conversation
ronag
changed the title
nodejs-github-bot
added
build
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 20, 2021
Adds a helper util used to determine whether a stream has been disturbed (read or cancelled). Refs: nodejs#39627 PR-URL: nodejs#39628 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Backport-PR-URL: nodejs#39819
ronag
force-pushed
the
backport-39628-to-v16.x
branch
from
ef6ccc1 to
574bec6
Compare
Adds a helper util used to determine whether a stream has been disturbed (read or cancelled). Refs: nodejs#39627 PR-URL: nodejs#39628 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Backport-PR-URL: nodejs#39819
ronag
force-pushed
the
backport-39628-to-v16.x
branch
from
574bec6 to
cd6f6c8
Compare
Member
Author
|
@nodejs/streams |
benjamingr
approved these changes
Aug 21, 2021
targos
reviewed
Aug 22, 2021
Co-authored-by: Michaël Zasso <targos@protonmail.com>
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Member
|
I think this one will be easier to do after #39563 ? |
Member
Author
Why? I don't think they are related? I think this can land now? |
Member
Author
|
CI linting error on markdown which I can't figure out. 😕 |
Member
You're right. I'm mixing things |
Member
It was because 0073831 was missing from v16.x-staging. It's there now. |
Member
|
Landed in af7047a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.