Skip to content

[v16.x backport] stream: add stream.compose #39563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[v16.x backport] stream: add stream.compose #39563

wants to merge 7 commits into from

Conversation

@ronag
Copy link
Member

@ronag ronag commented Jul 28, 2021

No description provided.

@ronag ronag changed the base branch from master to v16.x-staging July 28, 2021 12:32
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Jul 28, 2021
ronag added a commit to nxtedition/node that referenced this pull request Jul 28, 2021
@ronag
stream: add stream.compose
a94a29c 
Refs: nodejs#32020

PR-URL: nodejs#39029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#39563
@ronag ronag force-pushed the backport-39029-to-v16.x branch from fb7bee4 to a94a29c Compare July 28, 2021 12:32
@ronag ronag mentioned this pull request Jul 28, 2021
Closed
@ronag
Copy link
Member Author

ronag commented Jul 28, 2021

@nodejs/streams

This was referenced Jul 28, 2021
Closed
Closed
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 28, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39314/

mcollina
mcollina approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 29, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 29, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39329/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 29, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39331/

@bricss bricss mentioned this pull request Jul 29, 2021
Merged
@ronag ronag force-pushed the backport-39029-to-v16.x branch from c55be7d to 99e2820 Compare July 29, 2021 13:50
ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2021
@ronag
stream: add stream.compose
d114c0a 
Refs: nodejs#32020

PR-URL: nodejs#39029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#39563
ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2021
@ronag
stream: add stream.compose
ee65c9c 
Refs: nodejs#32020

PR-URL: nodejs#39029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#39563
@ronag ronag force-pushed the backport-39029-to-v16.x branch from 99e2820 to 2722246 Compare July 29, 2021 13:51
@targos
Copy link
Member

targos commented Aug 1, 2021

Can you please rebase (a commit was removed from staging)?

@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 1, 2021
@ronag ronag force-pushed the backport-39029-to-v16.x branch 2 times, most recently from 1d2ffc6 to 1314e35 Compare August 23, 2021 13:54
@ronag ronag marked this pull request as ready for review August 23, 2021 13:56
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@ronag
stream: add stream.compose
7663895 
Refs: nodejs#32020

PR-URL: nodejs#39029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#39563
@ronag ronag force-pushed the backport-39029-to-v16.x branch from 1314e35 to 7663895 Compare August 23, 2021 13:58
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39644/

@ronag ronag requested a review from targos August 23, 2021 14:11
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39645/

@ronag ronag removed the blocked PRs that are blocked by other issues or PRs. label Aug 23, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39648/

@targos
Copy link
Member

targos commented Aug 23, 2021

test-stream-compose.js is failing again

@ronag ronag requested a review from mcollina August 24, 2021 13:01
@ronag
Copy link
Member Author

ronag commented Aug 24, 2021

This need a few more things to make it pass.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39655/

@ronag ronag mentioned this pull request Aug 24, 2021
Closed
@ronag
Copy link
Member Author

ronag commented Aug 24, 2021

@nodejs/streams this needs an extra eye since it's not a straightforward backport.

@targos
Copy link
Member

targos commented Aug 24, 2021

To the reviewers: note that this also contains the changes from #39435 and #39494

@ronag
Copy link
Member Author

ronag commented Aug 24, 2021

Also some changes from #39294

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39656/

targos pushed a commit that referenced this pull request Sep 6, 2021
@ronag @targos
stream: add stream.compose
cb44781 
Refs: #32020

PR-URL: #39029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: #39563
@targos
Copy link
Member

targos commented Sep 6, 2021

Landed in cb44781

@targos targos closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@targos targos Awaiting requested review from targos

@mcollina mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag @nodejs-github-bot @targos @mcollina @benjamingr