fs: combine require() and destructure #39806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit combines two require() calls and subsequent destructuring operations.
nodejs-github-bot
added
fs
lpinca
approved these changes
Aug 19, 2021
aduh95
approved these changes
Aug 19, 2021
BethGriggs
approved these changes
Aug 19, 2021
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Aug 19, 2021
jasnell
approved these changes
Aug 20, 2021
cjihrig
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in af45be7...1deafcd |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 21, 2021
This commit combines two require() calls and subsequent destructuring operations. PR-URL: #39806 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 22, 2021
This commit combines two require() calls and subsequent destructuring operations. PR-URL: #39806 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit combines two
require()calls and subsequent destructuring operations.Side note: it looks like the new
cp()methods use thereaddir()functions. I imagine that people will usecp()to copy large directory trees. We should probably look into incorporating the streaming read dir functions.