This repository was archived by the owner on Jan 7, 2025. It is now read-only.
1.0.0-alpha2 merge request for new tagged release. #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulp-issue98 Feature/improvements to gulp issue98
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.20) Signed-off-by: dependabot[bot] <support@github.com>
Fix failing automated tests
…tchers so it can be tested as a first pass
- Uncomments the logo line. - Adds theme variables for site name and slogan - Uses the site name as the alt and title text - Fix the max height of the logo to 100px (6.25rem)
Replace placeholder with theme set logo
…urcemaps Fix linting issues and fix sourcemap URLs
- Apply the menu colums logic to the mega row menus - Use bootstrap classes on Drupal menu templates - Nudge the padding and margin in the megarow menu and the responsive menu
…odash-4.17.20 Bump lodash from 4.17.15 to 4.17.20
Use the Drupal defined menu for the primary navigation
…drupal/localgov_theme into feature/78-starterkit
Add 6 footer regions (3 upper and 3 lower). Use markup same as template to wrap regions
…ixes Feature/116 move layout fixes
…-stylesheet Add new stylesheet for CK editor iframes
…ests Feature/automated theme tests
Add footer regions to footer templates
…on-favicons Replace the croydon icon with a placeholder
paulpopus
approved these changes
Oct 27, 2020
Collaborator
paulpopus
left a comment
paulpopus
left a comment
There was a problem hiding this comment.
Looks good to me, I think tests need to be sorted out but that will happen in another issue.
cjstevens78
approved these changes
Oct 27, 2020
Member
Author
|
It would be nice to see the tests pass, but I would not object to this being merged if urgent. If we can wait for this to be merged localgovdrupal/localgov_project#24 then we will have the satisfaction of seeing the tests pass before merging. I realise I ended up creating the PR @cjstevens78 - sorry - which means I should really merge it. But like I say, happy for you to if you need it sooner. |
Member
Author
|
Oh - actually, all the tests do pass: OK (74 tests, 1095 assertions) It's only the PHPO error that's triggering the failure: |
Contributor
All good now. Thanks for promptly dealing with localgovdrupal/localgov_project#24 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, merge request into release branch before tagging.
In my opinion, this is just a sanity check to confirm the expected commits are going into the release.
All the merge requests that went into the master branch should already have been peer reviewed, so this could just be a 'lookls good to me' from those in the know.
Happy to hear your thoughts @andybroomfield @cjstevens78 @paulpopus