Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Conversation

@andybroomfield
Copy link
Contributor

@andybroomfield andybroomfield commented Oct 15, 2020

Fix #94.

This uses the Drupal primary menu for the menu
Also restyles the dropdows to appoximate the main menu style.

@andybroomfield andybroomfield marked this pull request as draft October 15, 2020 20:16
@andybroomfield
Copy link
Contributor Author

Having trouble replicating the service style big dropdown for standard dropdown elements.
Would current be acceptible and then use the megarow expanded section as a region?
Screenshot 2020-10-15 at 9 22 55 pm

@cjstevens78 cjstevens78 marked this pull request as ready for review October 20, 2020 15:43
@andybroomfield andybroomfield force-pushed the feature/94-menu-navbar branch 2 times, most recently from e311be5 to 43c8d81 Compare October 20, 2020 20:33
@cjstevens78
Copy link
Collaborator

@andybroomfield I'll pull this into my local tomorrow and take a look - im a bit worried the work involved to get it looking right might take me away from the croydon migration.

@andybroomfield
Copy link
Contributor Author

@cjstevens78 To demo this you need to create a menu under structure -> menu and add its block to the primary and/or secondary menu region. Shouldn't effect your Croydon verison if your overridding the header region template, though you may find it useful to use the technique in your own theme in the future.

@andybroomfield
Copy link
Contributor Author

Screenshot 2020-10-21 at 3 39 47 pm

Thats the current version.
I've completed the templating work, making sure it renders the menu regions.
I had to fiddle with the styles to get it to look right, but since I don't know the css standards being applied, best to let someone with more domain knowledge to pick those up.

andybroomfield and others added 8 commits October 22, 2020 15:51
- Adjust the menu--main.html.twig markup to match bootstrap
- Change the region name to services_menu
- Change the menu link to services
- Only show if the region has items
- Add services menu alone to the services mega row region
- Fix the colours in case plain text blocks added.
- Apply the menu colums logic to the mega row menus
- Use bootstrap classes on Drupal menu templates
- Nudge the padding and margin in the megarow menu and the responsive menu
@andybroomfield
Copy link
Contributor Author

@cjstevens78 Had to update this branch to avoid merge conflicts, can this be reviewed soonish before more fixes as its getting a awkward to deal with merge conflicts when rebasing from master.

@cjstevens78
Copy link
Collaborator

@cjstevens78 Had to update this branch to avoid merge conflicts, can this be reviewed soonish before more fixes as its getting a awkward to deal with merge conflicts when rebasing from master.

@andybroomfield apologies ! approved

@andybroomfield andybroomfield merged commit e8377af into master Oct 22, 2020
@andybroomfield
Copy link
Contributor Author

Thanks @cjstevens78 :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the hard coded header with drupal main menu

3 participants