Add footer regions to footer templates

[andybroomfield]

Fix #96.

This will replace the footer markup with Drupal regions.

Add 6 footer regions (3 upper and 3 lower).
Use markup same as template to wrap regions

Note: This does not recreate the blocks, so custom blocks will have to be created.

[paulpopus]

@andybroomfield is the intention to eventually include the blocks as config? I know that we can include config with the theme and it gets pulled in on installation

[andybroomfield]

@paulpopus Yes, though whether in the theme or in localgov_core is an open question and if we want to recreate the blocks exactly or have a settings page of the data.

For now the powered by localgov block is part of localgov_core and copyright block can be used for the copyright statement and footer menu for the menu. The rest can just use custom blocks until we can make something configurable.

[Adnan-cds]

Sorry, I can't find the closing nav tag :(

[Adnan-cds]

Hi Andy,
The footer solution for the localgov_theme is clearly broken. The info file declares footer_first and footer_second regions whereas footer.html.twig tries to render the non-existent Footer region. If I were fixing this, my approach would be as follows:

• Declare just one "footer" region and render it in footer.html.twig. Wrap this footer theme variable with necessary markup (e.g. <footer class="row">...{{ page.footer }}...</footer>).
• Remove all static content from footer.html.twig and turn them into as many blocks as appropriate.
• Add these blocks to a new module called localgov_blocks. This module can become a submodule of localgov_core although it doesn't have to be.
• Add the block_class contrib module as a dependency of localgov_blocks.
• Apply necessary classes (e.g. block--foo, col-lg-3, col-12, etc.) to these blocks from the block config page and then export the block config.
• Lastly, add these blocks to the Footer region and let Bootstrap arrange them according to their grid-specific classes.

This is quite different from the approach taken in this pull request. So possibly too late but I thought I will bring it to your attention anyway. The rational behind this approach is to keep the layout open to anything that Bootstrap can achieve rather than having multiple regions of fixed width.

[andybroomfield]

FAO @Adnan-cds New footer regions declared here.

[Adnan-cds]

The footer solution for the localgov_theme is clearly broken.

Hi Andy, I was referring to the current master branch. Sorry, should have been clearer.

[andybroomfield]

:-)

[andybroomfield]

• Declare just one "footer" region and render it in footer.html.twig. Wrap this footer theme variable with necessary markup (e.g. <footer class="row">...{{ page.footer }}...</footer>).
• Remove all static content from footer.html.twig and turn them into as many blocks as appropriate.
• Add these blocks to a new module called localgov_blocks. This module can become a submodule of localgov_core although it doesn't have to be.
• Add the block_class contrib module as a dependency of localgov_blocks.
• Apply necessary classes (e.g. block--foo, col-lg-3, col-12, etc.) to these blocks from the block config page and then export the block config.
• Lastly, add these blocks to the Footer region and let Bootstrap arrange them according to their grid-specific classes.

Hi @Adnan-cds thanks for the suggestions. I think we also have to consider this being used by non experinced / first time themers and thats quite a lot just to get started. The soloution here is simmilar to many Drupal themes, like Bootstrap Barrio, which give a fixed set of regions to drop blocks into. If someone was comftable setting up extra modules and block class, they are very likley making a child theme that goes beyond changing colours and fonts and so will override the footer.html.twig template to their exact taste anyway.

I think it would be useful to set some guidance on what we are expecting the base theme to provide and the technical expertise we expect from the people using it. Thoughts from others welcome.

[andybroomfield]

Merging in the footer regions, Will add new issue in localgov_core to recreate the blocks.