phpcs incompatibility #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squizlabs/php_codesniffer versions 3.5.7 and 3.5.8, the two latest ones, are throwing PHP fatal errors. So sticking with version 3.5.6 for now. Sample error message: ``` PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function DrupalPractice\Sniffs\CodeAnalysis\ScopeInfo::__construct(), 0 passed in <snipped>/localgov-project/vendor/squizlabs/php_codesniffer/src/Ruleset.php on line 1209 and exactly 1 expected in <snipped>/localgov-project/vendor/drupal/coder/coder_sniffer/DrupalPractice/Sniffs/CodeAnalysis/VariableAnalysisSniff.php:49 ... ``` Issue #23
finnlewis
reviewed
Oct 27, 2020
Member
finnlewis
left a comment
finnlewis
left a comment
There was a problem hiding this comment.
Looks good @Adnan-cds - let's get this in to unblock all the other tests!
Member
|
Sorry @stephen-cox - I pressed the wrong thing and re-requested your review. That was not intentional. |
finnlewis
approved these changes
Oct 28, 2020
Contributor
Author
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squizlabs/php_codesniffer versions 3.5.7 and 3.5.8, the two latest ones, are
throwing PHP fatal errors. So sticking with version 3.5.6 for now.
Sample error message:
Resolves #23