CodeSniffer is suffering PHP Fatal errors

[Adnan-cds]

Test runs are failing due to issues with PHP Code sniffer. It had two releases in the last 4 days and these releases (3.5.7, 3.5.8) are leading to this fatal error. Version 3.5.6 works okay. I am wondering if we need to pin squizlabs/php_codesniffer to 3.5.6.

How to reproduce

$ composer create-project --stability dev localgovdrupal/localgov-project
$ pushd localgov-project
$ ./bin/phpcs # this leads to the PHP fatal error
$ composer require --dev squizlabs/php_codesniffer:3.5.6
$ ./bin/phpcs # This one should be alright
$ echo $?

FAO @stephen-cox @finnlewis

[finnlewis]

I've got no objections to pinning squizlabs/php_codesniffer to 3.5.6. for now if that's the quicker way to prevent eroneously failing tests.

[stephen-cox]

We've already has to pin PHP Stan for a similar reason (

localgov_project/composer.json

Line 26 in 350857e

"phpstan/phpstan": "0.12.42",

) so no objections to pinning Code Sniffer

[Adnan-cds]

Thanks, I will try to raise a pull request today given the urgency of the matter.