This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Replace placeholder with theme set logo #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andybroomfield
commented
Oct 15, 2020
andybroomfield
commented
- Uncomments the logo line.
- Adds theme variables for site name and slogan
- Uses the site name as the alt and title text
- Fix the max height of the logo to 100px (6.25rem)
Contributor
Author
|
We could do with rejigging the logo after this, as there is whitespace in the logo itself.
|
Contributor
Author
|
Theres also a branding block included with the theme, would that be better to use instead of the fixed logo? |
cjstevens78
approved these changes
Oct 20, 2020
- Uncomments the logo line. - Adds theme variables for site name and slogan - Uses the site name as the alt and title text - Fix the max height of the logo to 100px (6.25rem)
andybroomfield
force-pushed
the
fix/95-enable-logo
branch
from
d7af6b5 to
cff0d70
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.