[3.2] Fix splash screen loading on Android #41384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles Utility methods for writing files to gradle project directory
Factor out finding permissions and command line flags
Create strings.xml files for project name translations
Copy project icons to Gradle project directory during Android Custom Build.
Write AndroidManifest.xml for Gradle project
Refactor APK signing into its own method
Add 'Export App Bundle' to Android Export Options
m4gr3d
force-pushed
the
fix_splash_loading_3_2
branch
from
992faf4 to
80d8c61
Compare
m4gr3d
changed the title
m4gr3d
force-pushed
the
3.2-android-app-bundle
branch
2 times, most recently
from
7031c3c to
59da1db
Compare
|
@akien-mga should I reopen this PR against the 3.2 branch? |
|
Ah, it got closed because the target branch was deleted I guess? Then yes, unless this one can be reopened with its target branch changed. |
|
(Well I see the reopen button is greyed out, so a new PR will be necessary.) |
|
Replaced by PR #42389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #21824
This is done by leveraging the Android theme to setup the app splash screen (reference).
Note:
fullsizeanduse filterparameters are not supported due to limitations of the Android theme api3.2-android-app-bundlebranch since that branch includes numerous updates to the Android build process.