Copy project icons to Gradle project directory during Android Custom Build. #39997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanj120
commented
Jul 13, 2020
amanj120
force-pushed
the
bundle_pr_icons
branch
from
a1d5603
to
72e9d6e
Compare
m4gr3d
requested changes
Jul 17, 2020
amanj120
force-pushed
the
bundle_pr_icons
branch
4 times, most recently
from
2212fef
to
2bd83ad
Compare
m4gr3d
requested changes
Jul 22, 2020
amanj120
force-pushed
the
bundle_pr_icons
branch
2 times, most recently
from
c0f9002
to
84868c4
Compare
amanj120
force-pushed
the
bundle_pr_icons
branch
from
b65ec59
to
fbf70fe
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to copy the project icons into the Gradle project directory is a necessary step in moving towards a gradle-based build system that can export Android App Bundles. For more details on the final scope of this project, read this comment.
These methods aren't currently called anywhere in the code, but they will be useful in subsequent PR's.
We are working on this PR with @m4gr3d, as explained here
This PR builds on top of a previous PR I've submitted. There are a lot of changes that need to be made to move towards a Gradle-based build system, so I have broken these changes into smaller, more understandable steps.