-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Export App Bundle' to Android Export Options #40685
Add 'Export App Bundle' to Android Export Options #40685
Conversation
@akien-mga For the UI, another option is to replace
The issue with this approach of course if that it would be slightly breaking compatibility as opposed to the current which, while not the best UX, does the job and doesn't break compatibility. |
de2bb94
to
0136f06
Compare
383317e
to
cfe1efe
Compare
5908955
to
7cc064d
Compare
010cfd1
to
4a1a9cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@amanj120 Don't forget to squash the commits. |
4dff77c
to
f185ad7
Compare
f185ad7
to
69effb1
Compare
I am so looking forward to this btw. |
Thanks! |
Does this support Play Asset Delivery and/or Play Feature Delivery. I'm interested in separating parts of my game which are In app purchase access only. |
@fuzzypurplepixel This PR doesn't and it won't be available in Godot 3.2.4, but we're working on making it available in a future release. |
The final step in moving towards a gradle-based build system that can export Android App Bundles is to add the user interface element. For the 3.x release, and following the contribution guidelines, I think the simplest way to do this is to add a drop down menu to be able to Export as AAB. This option will not work unless
Use Custom Build
is also selected. For more details on the final scope of this project, read this comment.The default value for this drop down menu is
Export APK
. IfUse Custom Build
is not selected, thenExport APK
follows the legacy build system. IfUse Custom Build
is selected andExport APK
is selected, then it follows the normalUse Custom Build
system.The PR for the 4.0 branch might look different depending on how much of the legacy build system we want to retain.
We are working on this PR with @m4gr3d, as explained here
This PR builds on top of many previous PRs I've submitted. There are a lot of changes that need to be made to move towards a Gradle-based build system, so I have broken these changes into smaller, more understandable steps.