Write AndroidManifest.xml for Gradle project #40609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanj120
force-pushed
the
bundle_pr_manifest
branch
2 times, most recently
from
ab09b9e
to
183fd7f
Compare
amanj120
force-pushed
the
bundle_pr_manifest
branch
2 times, most recently
from
8dcb2e1
to
70c45c6
Compare
amanj120
force-pushed
the
bundle_pr_manifest
branch
from
70c45c6
to
691a685
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to the AndroidManifest.xml file is a necessary step in moving towards a gradle-based build system that can export Android App Bundles. To do this, we will use manifest merging so we can avoid parsing the already existing manifest file. For more details on the final scope of this project, read this comment.
We are working on this PR with @m4gr3d, as explained here
This PR builds on top of many previous PRs I've submitted. There are a lot of changes that need to be made to move towards a Gradle-based build system, so I have broken these changes into smaller, more understandable steps.