Factor out finding permissions and command line flags #39998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: There will also have to be a corresponding PR for master for this to be merged. |
m4gr3d
requested changes
Jul 6, 2020
m4gr3d
requested changes
Jul 7, 2020
amanj120
force-pushed
the
bundle_pr_permissions
branch
from
ccf456b
to
7b8332e
Compare
akien-mga
reviewed
Jul 8, 2020
akien-mga
reviewed
Jul 8, 2020
akien-mga
reviewed
Jul 8, 2020
amanj120
force-pushed
the
bundle_pr_permissions
branch
2 times, most recently
from
2a41895
to
9f7d9a6
Compare
m4gr3d
approved these changes
Jul 9, 2020
amanj120
force-pushed
the
bundle_pr_permissions
branch
from
9f7d9a6
to
bd47bd7
Compare
This was referenced Jul 9, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factoring out these two features is useful because they will need to be called in many different circumstances. This will be useful for transitioning to a Gradle-based build system. For more details on the final scope of this project, read this comment. There are a lot of changes that need to be made to move towards a Gradle-based build system, so I have broken these changes into smaller, more understandable steps.
We are working on this PR with @m4gr3d, as explained here