Refactor permissions and command line flags into separate methods #40244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanj120
force-pushed
the
forward_port_bundle_pr_permissions
branch
from
bfb0a06
to
f579057
Compare
akien-mga
changed the title
|
Thanks! |
|
Do you have a timeline on when the corresponding PR on the 3.2 branch #39998 will be merged? |
|
At least after the 3.2.3 release which focuses on Bugfixes (should be out in a week or two). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward port of #39998 to the master branch
Note, there are some changes in the semantics (i.e.
nullptrvsNULL) which means that this code is not verbatim the code from #39998.