-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create strings.xml files for project name translations #40182
Create strings.xml files for project name translations #40182
Conversation
6b26405
to
0ac0d81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach used here has visibility issues.
Unless a contributor is familiar with the added logic here, she/he may inadvertently create a string resource file in the project and be confused when the end result is not as expected since this logic would overwrite that file.
Even when a contributor is familiar with this logic, the addition of new string values now becomes a cumbersome task.
What about the approach of having the string resources already in the gradle project (e.g: moving them from the lib
to the app
module) and just overwriting the target string value?
0ac0d81
to
9df67bf
Compare
1d34bd9
to
aa87e3d
Compare
3cff169
to
0b02158
Compare
I'm replying to this to indicate that we've resolved this issue. |
b53a0ab
to
d036543
Compare
d036543
to
9715110
Compare
3f139d6
to
f0e1cb8
Compare
Changes look good overall, though I have the same nitpicks on some of the |
19b6e28
to
d9e5919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the commits for this PR.
d9e5919
to
8376abf
Compare
Thanks! |
When a Godot game is being exported, one of the processes that takes place is that the resource table is modified to have different translations of the project name. This PR accomplishes the same purpose by writing strings.xml files in the Gradle project directory.
Note: This PR builds off of #39864, the
store_string_at_path
method will be provided through that PR.For more details on the final scope of this project, read this comment.
The
_create_project_name_strings_files
method isn't currently called anywhere in the code, but it will be useful in subsequent PR's.We are working on this PR with @m4gr3d, as explained here