[WIP] Terms Filter Control targeting Visualize Refactor #12126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
force-pushed
the
feature/visualize
branch
from
0de721f
to
b09014f
Compare
ppisljar
force-pushed
the
feature/visualize
branch
9 times, most recently
from
0e3d49f
to
8f9f1db
Compare
ppisljar
force-pushed
the
feature/visualize
branch
4 times, most recently
from
63e1421
to
abf0a6d
Compare
thomasneirynck
force-pushed
the
feature/visualize
branch
from
0786437
to
f844475
Compare
ppisljar
force-pushed
the
feature/visualize
branch
from
20bf21c
to
033806a
Compare
thomasneirynck
force-pushed
the
feature/visualize
branch
from
033806a
to
6fc6a41
Compare
This reorganizes the internals of Visualize. The main contributions are: - separation of Editor from Visualization. This allows users to create editors separate from their Visualization. Both Timelion and TSVB are examples of visualizations not using the sidebar editor - no longer restricted to just use angular as a rendering technology - introduction of API object, which avoids the need to pull in modules directly, like time-filter or filter-bar
…stic#12379) * Adding option for dropping last bucket to TSVB * updating tests to reflect new behaivor * updating tests
elastic#11209) * [logging] Downgrade hapi connection errors when connecting with the wrong protocol * [logging] Check for error code instead of message for requesting https when serving http errors
* Beginning to update the healthcheck to use the SavedObjectsClient Some tests are still broken The sort method on the SavedObjectsClient isn't there yet * Adding sort to create_find_query * Fixing the tests * Fixing upgrade_config tests * Making the SavedObjectsClient be dependant on the mappings to enable sorting * Fixing disabled tests * Fiixng test wording * Passing the savedObjectsClient to the stats route handler * Passing the savedObjectsClient to upgradeConfig from migratConfig * Using array of keys with _.get instead of manual string concatenation
…screen-reader accessible. (elastic#13046) * Make 'time picker' button in Discover no results prompt keyboard and screen-reader accessible.
* handle data sets with holes * add unit tests
* Fix incorrect peerDependency and bump eslint config version to 0.8.1. * Upgrade eslint config to 0.8.1. Fix JSX to adhere to new formatting rules.
Since versions are synced across the stack, the esvm config can use the same branch configuration as Kibana itself.
* Stabalize tests and bring back flaky test * Try to fix flaky map radius visualize test * fix flaky tile map zoom test * Try to fix flaky zoom test by avoiding zooming in and out with spy panel open * Remove duplicate wrapped retry around find methods The retry was moved internally, around a check for stale elements as well, so this should no longer be neccessary.
… when loading Console app state. (elastic#13092)
* adding docs for goal and gauge
…agated to the UI (elastic#13004) * Remove try/catch for short url so the appropriate errors will be propagated to the UI * Simply ensure the error is a Boom error by wrapping it, but keep the original error details. * Boom.wrap can't handle non Error instances, as exist in some of the tests. * Only support Error objects, and check both status and statusCode * fix test * Fix test errors for reals this time * Break out status and statusCode short url error tests
…ic#13070) * Ensure that conflict fields can be searchable and/or aggregatable in the UI * Use `some` instead of `reduce` * Revert UI changes * Attempt to convert multiple ES types to kibana types, and if they all resolve to the same kibana type, there is no conflict * Add comma back * Cleaner code * Add tests * Update failing test to handle searchable and aggregatable properly * Add functional test to ensure similar ES types are properly merged * Update tests * Revert shard size
* [es/tests] remove unused module * [testUtil/es] add utility for starting es nodes in tests * [ftr/tests] use esTestCluster util to start es * [es/tests/routes] use esTestCluster to start own es * [testUtils/kbnServer] disable uiSettings unless plugins are enabled * [testUtils/esTestCluster] use standard test es port by default * [server/http/tests] add esTestCluster to setup * [test/config] unify es test config into a single module * [testUtils/esTestCluster] directory is no longer configurable * [testUtils/esTestCluster] throw when es.start() is called again without es.stop() * [testUtils/esTestCluster] is* checks should not mutate state
* Fixes elastic#13181 - Check values before adding them to filter * Adding tests * Adding check to make sure query is never undefined
|
Works with the new visualization refactor. Linking to #11935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.