changes needed to make default editor work with react component (#12196)

elastic · Jun 7, 2017 · 0de721f · 0de721f
1 parent b5f18e9
commit 0de721f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/ui/public/vis/editors/default/default.js b/src/ui/public/vis/editors/default/default.js
@@ -17,7 +17,7 @@ const defaultEditor = function ($rootScope, $compile) {
 
       if (!this.vis.type.editorConfig.optionTabs && this.vis.type.editorConfig.optionsTemplate) {
         this.vis.type.editorConfig.optionTabs = [
-          { name: 'options', title: 'Options', editor: this.editorConfig.optionsTemplate }
+          { name: 'options', title: 'Options', editor: this.vis.type.editorConfig.optionsTemplate }
         ];
       }
     }

diff --git a/src/ui/public/vis/editors/default/vis_options.js b/src/ui/public/vis/editors/default/vis_options.js
@@ -28,7 +28,7 @@ uiModules
       const reactOptionsComponent = typeof $scope.editor !== 'string';
       const renderReactComponent = () => {
         const Component = $scope.editor;
-        render(<Component scope={$scope} />, $el);
+        render(<Component scope={$scope} />, $el[0]);
       };
       // Bind the `editor` template with the scope.
       if (reactOptionsComponent) {
@@ -50,7 +50,7 @@ uiModules
 
       $el.on('$destroy', () => {
         if (reactOptionsComponent) {
-          unmountComponentAtNode($el);
+          unmountComponentAtNode($el[0]);
         }
       });
     }