Visualize refactor (bis) #12715
Merged
Visualize refactor (bis) #12715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing tests fixing tsvb auto apply button fix tsvb resizing issue update scope.$apply for react editor components re-render react component when vis.params are updated (#12347) fixing heatmap remove obsolete maps_renderbot indirection remove cruft/ remove custom resizing and hook into global event fixing brush event fixing resize event for vislib_vis_type fixing legend changing based on nathans review
thomasneirynck
force-pushed
the
feature/visualize
branch
from
033806a
to
6fc6a41
Compare
thomasneirynck
added
the
Feature:Visualizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening the refactor pull (#11786).
Merging this broke Xpack, so reverted the original PR (#12711). Let's resolve those issues on Xpack side first before merging this again.
Added one change which differs with the original PR (#11786). It moves
service_settingsto an accessible location (40909bf).cc @ppisljar