Should respect pinned filters #13019
Conversation
thomasneirynck
added
Feature:Visualizations
| const responseHandler = getHandler(responseHandlers, $scope.vis.type.responseHandler); | ||
|
|
||
| $scope.fetch = _.debounce(function () { | ||
| .directive('visualize', function (Notifier, Private, timefilter, getAppState) { |
There was a problem hiding this comment.
seems github messed up this comparison ? shows whole file is different where only a couple of lines changed ....
There was a problem hiding this comment.
not sure. maybe a lintroller thing..
| const requestHandlers = Private(VisRequestHandlersRegistryProvider); | ||
| const responseHandlers = Private(VisResponseHandlersRegistryProvider); | ||
| const ResizeChecker = Private(ResizeCheckerProvider); | ||
| const queryFilter = Private(FilterBarQueryFilterProvider); |
There was a problem hiding this comment.
i am not really sure about using queryFilter here ...
what about using globalState service to retrieve the filters from there ?
There was a problem hiding this comment.
queryFilter is more more specific, but much easier to use .... appState + globalState are more generic .... but we shouldn't probably use them directly if we already have abstractions on top of it.
src/ui/public/visualize/visualize.js
Outdated
|
|
||
| // searchSource is only there for courier request handler | ||
| requestHandler($scope.vis, $scope.appState, $scope.uiState, $scope.savedObj.searchSource) | ||
| requestHandler($scope.vis, $scope.appState, $scope.uiState, $scope.savedObj.searchSource, queryFilter) |
There was a problem hiding this comment.
put the queryFilter before searchSource (searchSource is kind of BWC parameter which only courier request handler should use
also we should get rid of appState (query filter can retrieve the query and the filters right ?)
There was a problem hiding this comment.
not sure if we should. appState has that .linked flag we require. would keep this a spot fix for now.
src/ui/public/visualize/visualize.js
Outdated
| if (keys[0] === 'uiState') { | ||
| $scope.$on('fetch', reload); | ||
| queryFilter.on('update', () => { | ||
| $scope.fetch(); |
There was a problem hiding this comment.
no need to wrap this function ....
queryFilter.on('update', $scope.fetch);
…ges in the app-state
thomasneirynck
force-pushed
the
fix/should_respect_pinned_filters
branch
from
86e3ba0
to
a807147
Compare
Closes #13011.
Not sure if this is the best solution, but wanted something up that we can use to discuss around.
The problem is that Visualize is not refreshing when there are changes in the filters of the
globalState. A pinned filter is a global filter, and not present in theappState, so when we pin the filter, it does not create a refresh, and neither are they applied..the
queryFilterobject provides a listener on both fitlers in the app and global state, and provides access to both the filter and the query object.It may be worth considering just to remove the usage of
appStatein the courier request handler and visualize-directirve to retrieve query/filters and usequeryFiltersfor that purpose instead. But not sure if that is going to have any other impact.