Save layer setting in the region map UI #12956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
review
v5.5.1
v5.6.0
v6.0.0
Feature:Visualizations
ppisljar
requested changes
Jul 19, 2017
| @@ -15,6 +15,14 @@ uiModules.get('kibana/region_map') | |||
|
|
|||
| $scope.collections = $scope.vis.type.editorConfig.collections; | |||
|
|
|||
| $scope.initializeLayerSetting = function () { | |||
| $scope.vis.params.selectedLayer = $scope.collections.vectorLayers[0]; | |||
There was a problem hiding this comment.
this should be defined in the vis definition (visConfig.defaults) as we do with all the other settings, and then you don't need the ng-init part.
thomasneirynck
force-pushed
the
fix/save_layer_setting
branch
from
0098b05
to
fdd3883
Compare
|
jenkins, test this |
|
PR probably requires rebase, breaking on single_type issue. |
thomasneirynck
force-pushed
the
fix/save_layer_setting
branch
from
fdd3883
to
58388d7
Compare
|
jenkins, test this |
2 similar comments
|
jenkins, test this |
|
jenkins, test this |
thomasneirynck
force-pushed
the
fix/save_layer_setting
branch
from
58388d7
to
5171248
Compare
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 27, 2017
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 27, 2017
Includes manual edits to resolve merge conflicts.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 27, 2017
Includes manual edits to resolve merge conflicts.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 27, 2017
thomasneirynck
added a commit
that referenced
this pull request
Jul 28, 2017
thomasneirynck
added a commit
that referenced
this pull request
Jul 28, 2017
thomasneirynck
added a commit
that referenced
this pull request
Jul 28, 2017
thomasneirynck
added a commit
that referenced
this pull request
Jul 28, 2017
epixa
pushed a commit
that referenced
this pull request
Jul 28, 2017
|
This should go into 5.6 rather than 5.x. I cherry-picked it over 0a21221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note: The layer selection is now preserved in the UI dropdown when saving a Region Map.
closes #12172.