[testUtils/esTestCluster] use more standard api style #13197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added a commit
that referenced
this pull request
Jul 28, 2017
(cherry picked from commit d36080b)
spalger
added a commit
that referenced
this pull request
Jul 28, 2017
(cherry picked from commit d36080b)
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Aug 9, 2017
(cherry picked from commit d36080b)
|
Backporting to 5.6 in #13408 |
spalger
added a commit
that referenced
this pull request
Aug 9, 2017
* [partial backport] extract kbnServer test utils from #12554 * Implement esTestCluster test util (#13099) * [es/tests] remove unused module * [testUtil/es] add utility for starting es nodes in tests * [ftr/tests] use esTestCluster util to start es * [es/tests/routes] use esTestCluster to start own es * [testUtils/kbnServer] disable uiSettings unless plugins are enabled * [testUtils/esTestCluster] use standard test es port by default * [server/http/tests] add esTestCluster to setup * [test/config] unify es test config into a single module * [testUtils/esTestCluster] directory is no longer configurable * [testUtils/esTestCluster] throw when es.start() is called again without es.stop() * [testUtils/esTestCluster] is* checks should not mutate state (cherry picked from commit 6748b22) * [testUtils/esTestCluster] use more standard api style (#13197) (cherry picked from commit d36080b) * [scanner] use new esTestConfig service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13099 added the esTestCluster test util, and used a somewhat strange API so that we could track state that wasn't "module level". That goal has already clashed with adding new features, and rather than keep down this road I think we should just track this tiny bit of state that is actually process specific at the module level.
The only impact this pr has on the rest of the code is that rather than calling
esTestCluster.use({ name: '...' })code should callcreateEsTestCluster({ name: '...' })