Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix new clippy lints before they reach stable #8700

Merged
merged 2 commits into from
May 29, 2023
Merged

fix new clippy lints before they reach stable #8700

merged 2 commits into from
May 29, 2023

Conversation

jakobhellermann
Copy link
Contributor

Objective

  • fix clippy lints early to make sure CI doesn't break when they get promoted to stable
  • have a noise-free clippy experience for nightly users

Solution

  • cargo clippy --fix
  • replace filter_map(|x| x.ok()) with map_while(|x| x.ok()) to fix potential infinite loop in case of IO error

@jakobhellermann jakobhellermann added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change labels May 28, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 28, 2023
@mockersf mockersf added this pull request to the merge queue May 29, 2023
Merged via the queue into bevyengine:main with commit 1ff4b98 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@nicopap nicopap nicopap approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobhellermann @alice-i-cecile @mockersf @nicopap