Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement Debug for dynamic types #5948

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Implement Debug for dynamic types #5948

wants to merge 2 commits into from

Conversation

afonsolage
Copy link
Contributor

@afonsolage afonsolage commented Sep 11, 2022 •
edited
Loading

Objective

When trying derive Debug for type that has DynamicEnum it wasn't possible, since neither of DynamicEnum, DynamicTuple, DynamicVariant or DynamicArray implements Debug.

Solution

Implement Debug for those types, using derive macro

Changelog

  • DynamicEnum, DynamicTuple, DynamicVariant and DynamicArray now implements Debug

NiklasEi
NiklasEi reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@NiklasEi NiklasEi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not implement Debug for all the Dynamic* structs? I did not look through all the types, but for example DynamicArray also doesn't implement it.

@afonsolage
Copy link
Contributor Author

afonsolage commented Sep 12, 2022 •
edited
Loading

Should we not implement Debug for all the Dynamic* structs? I did not look through all the types, but for example DynamicArray also doesn't implement it.

I didn't take a look in all Dynamic* also, I just needed Debug on DynamicEnum and added. I'll update this PR and add for all those Dynamic*s

@afonsolage afonsolage changed the title Implement Debug for DynamicEnum, DynamicTuple and DynamicVariant Implement Debug for dynamic types Sep 12, 2022
@NiklasEi NiklasEi added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Reflection Runtime information about types labels Sep 12, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 19, 2022
@afonsolage
Implement Debug for dynamic types (#5948)
d8e2811 
# Objective

When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`.

## Solution

Implement Debug for those types, using `derive` macro

---

## Changelog

- `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
@bors
Copy link
Contributor

bors bot commented Sep 19, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 19, 2022
@afonsolage
Implement Debug for dynamic types (#5948)
890e90a 
# Objective

When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`.

## Solution

Implement Debug for those types, using `derive` macro

---

## Changelog

- `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
@bors
Copy link
Contributor

bors bot commented Sep 19, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 19, 2022
@afonsolage
Implement Debug for dynamic types (#5948)
91a235e 
# Objective

When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`.

## Solution

Implement Debug for those types, using `derive` macro

---

## Changelog

- `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
@bors
Copy link
Contributor

bors bot commented Sep 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement Debug for dynamic types [Merged by Bors] - Implement Debug for dynamic types Sep 19, 2022
@bors bors bot closed this Sep 19, 2022
@afonsolage afonsolage deleted the derive_debug branch September 19, 2022 19:02
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@afonsolage @james7132
Implement Debug for dynamic types (bevyengine#5948)
ac6e0d8 
# Objective

When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`.

## Solution

Implement Debug for those types, using `derive` macro

---

## Changelog

- `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@afonsolage @james7132
Implement Debug for dynamic types (bevyengine#5948)
648f62d 
# Objective

When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`.

## Solution

Implement Debug for those types, using `derive` macro

---

## Changelog

- `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@afonsolage @ItsDoot
Implement Debug for dynamic types (bevyengine#5948)
a3d49c6 
# Objective

When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`.

## Solution

Implement Debug for those types, using `derive` macro

---

## Changelog

- `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@NiklasEi NiklasEi NiklasEi approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afonsolage @alice-i-cecile @NiklasEi @tim-blackbird