Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Slight changes from the book #4077

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Slight changes from the book #4077

wants to merge 1 commit into from

Conversation

reinismu
Copy link
Contributor

@reinismu reinismu commented Mar 1, 2022

Not sure if this is the new format, but quickly looking I couldn't wind a easy way to update it in the book

Objective

  • For sample project to compile after first pages of book

got:

  = note: clang: error: invalid linker name in argument '-fuse-ld=/usr/local/bin/zld'
          

error: linking with `cc` failed: exit status: 1

Solution

FIx to correct zld path

@reinismu
Slight changes from the book
06442a8 
Not sure if this is the new format, but quickly looking I couldn't wind a easy way to update it in the book
@alice-i-cecile
Copy link
Member

Not sure if this is the new format, but quickly looking I couldn't wind a easy way to update it in the book

A PR to https://github.com/bevyengine/bevy-website would be appreciated.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation O-MacOS Specific to the MacOS (Apple) desktop operating system labels Mar 2, 2022
@mockersf
Copy link
Member

mockersf commented Mar 5, 2022

The website doesn't mention where zld would be installed on mac.

This PRs update the path to the one where homebrew will install zld, and homebrew is recommended just above for that.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 5, 2022
@mockersf
Copy link
Member

mockersf commented Mar 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 5, 2022
@reinismu
Slight changes from the book (#4077)
0eec2ea 
Not sure if this is the new format, but quickly looking I couldn't wind a easy way to update it in the book

# Objective

* For sample project to compile after first pages of book

got: 

```
  = note: clang: error: invalid linker name in argument '-fuse-ld=/usr/local/bin/zld'
          

error: linking with `cc` failed: exit status: 1
```

## Solution

FIx to correct zld path
@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Slight changes from the book [Merged by Bors] - Slight changes from the book Mar 5, 2022
@bors bors bot closed this Mar 5, 2022
kurtkuehnert pushed a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@reinismu
Slight changes from the book (bevyengine#4077)
5cdd5e1 
Not sure if this is the new format, but quickly looking I couldn't wind a easy way to update it in the book

# Objective

* For sample project to compile after first pages of book

got: 

```
  = note: clang: error: invalid linker name in argument '-fuse-ld=/usr/local/bin/zld'
          

error: linking with `cc` failed: exit status: 1
```

## Solution

FIx to correct zld path
@ghost
Copy link

ghost commented Apr 15, 2022

Hello,

I think the changes introduced in this PR might not be accurate or there might be more to it @mockersf .
I followed the current instruction in the bevy book which suggest using the path /opt/homebrew/bin/zld on mac os x86_64. and I ran into the clang error in the first post, although this time it was saying = note: clang: error: invalid linker name in argument '-fuse-ld=/opt/homebrew/bin/zld'

I am using mac OS 10.15.7 x86_64.
Maybe this change depends on either the macOS version or the architecture ? Not sure would have to check the brew formula to see when each path is used.

Anyway for me changing back to '/usr/local/bin/zld' did the trick just thought I'd tell you.

@mockersf mockersf mentioned this pull request May 17, 2022
Closed
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@reinismu @aevyrie
Slight changes from the book (bevyengine#4077)
6a5f9c8 
Not sure if this is the new format, but quickly looking I couldn't wind a easy way to update it in the book

# Objective

* For sample project to compile after first pages of book

got: 

```
  = note: clang: error: invalid linker name in argument '-fuse-ld=/usr/local/bin/zld'
          

error: linking with `cc` failed: exit status: 1
```

## Solution

FIx to correct zld path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation O-MacOS Specific to the MacOS (Apple) desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reinismu @alice-i-cecile @mockersf