Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bevy simpleicon for smaller sizes #3728

Closed
wants to merge 1 commit into from

Conversation

Weasy666
Copy link
Contributor

@Weasy666 Weasy666 commented Jan 20, 2022

Objective

Improve the Bevy simpleicons for smaller sizes. This change makes it look like this:
bevy_simpleicons_webpage_grey

It is still not perfect at the smallest size. I don't think using just one bird is a good idea, because one bird is not a community and with only one bird it would look too similar to the twitter logo, which could result in some legal worries.

If you have different ideas, please voice them here. If you want to test and view them yourselves, just copy the path out of your SVG file and paste it here https://petershaggynoble.github.io/SI-Sandbox/preview/.

PS: The upstream (simpleicons.org) PR is this one simple-icons/simple-icons#7076. I will update it as soon as this PR is merged.

EDIT: Updated the simpleicon to the improved version from #4050.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 20, 2022
@james7132 james7132 added A-Meta About the project itself and removed S-Needs-Triage This issue needs to be labelled labels Jan 21, 2022
@ickk
Copy link
Member

ickk commented Jan 21, 2022

Given that the small badge size is likely to be one of if not the most common use of this, I think we need to improve the legibility at lot. At the moment it is very difficult to tell that it's even meant to be a bird, let alone three.

If removing paths & complexity is off-the-table, I don't know what the solution is beyond further expanding the gaps and/or trying to use the vertical space more effectively (could try rotating the image or something); it looks we're only using about 70% of the available vertical space, so there's free real-estate if we can figure out how to best utilise it.

@Weasy666
Copy link
Contributor Author

I didn't mean that a single bird is off the table, i just wanted to voice my concerns. I can't say if Twitter will have a problem with it, or if it they could even realistically take some legal action against it. I just wanted to mention it, so that we can keep something like that in mind.
Still, i would prefer a solution that keeps the idea of community, but...yeah...i agree that the birds are hard to discern at the small size. I don't really have a good solution, except widen the gap (but that is imo not really a good solution). That is why i wanted to discuss our options here.

@Weasy666
Copy link
Contributor Author

After noticing #4050, i'd like to bump this PR a bit.
@cart (sorry for pinging) Could you please share your opinion on this matter? Should we stay with the bevy of birds and try to separate the birds further with a bigger gap, or should we use a single bird, or even something else we haven't thought about. I'd really like to finish this up and do something with the open PR in the simpleicons repo 😅

@cart
Copy link
Member

cart commented Feb 27, 2022

Oops sorry for letting this fester. We should stay with the bevy of birds and give them a larger gap. I like what you did here:
image

If you apply the gap change to the new logo version from #4050, I'm on board!

@cart
Copy link
Member

cart commented Feb 27, 2022

In fact, I think we should consider increasing the gap size in the other logo variants too. Better to make the logo "scalable" everywhere rather than having two versions.

@cart
Copy link
Member

cart commented Feb 27, 2022

(but im happy to defer that decision until later if you just want to sort out the simpleicons situation first)

@Weasy666
Copy link
Contributor Author

I think, in this PR i will just update the simpleicon with the new logo from #4050. And open a new PR for the other icons. Will do that tomorrow, need to go to bed now. 😴

@Weasy666
Copy link
Contributor Author

Ok done. Follow up PR is #4061.

@ickk
Copy link
Member

ickk commented Mar 3, 2022

Just so we're all on the same page, this is how the (likely?) most commonly used icon size will render on regular (non-HiDPI) displays:

image image

image
Personally I find it quite hard to discern, but it seems like there's not a lot of good options to improve the situation.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 16, 2022
@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels May 30, 2022
@alice-i-cecile
Copy link
Member

Blocking this on #4061, and then we can merge these all at once.

@richchurcher
Copy link
Contributor

Closed (backlog cleanup), tracked in #15584 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta About the project itself S-Blocked This cannot move forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants