-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bevy simpleicon for smaller sizes #3728
Conversation
Given that the small badge size is likely to be one of if not the most common use of this, I think we need to improve the legibility at lot. At the moment it is very difficult to tell that it's even meant to be a bird, let alone three. If removing paths & complexity is off-the-table, I don't know what the solution is beyond further expanding the gaps and/or trying to use the vertical space more effectively (could try rotating the image or something); it looks we're only using about 70% of the available vertical space, so there's free real-estate if we can figure out how to best utilise it. |
I didn't mean that a single bird is off the table, i just wanted to voice my concerns. I can't say if Twitter will have a problem with it, or if it they could even realistically take some legal action against it. I just wanted to mention it, so that we can keep something like that in mind. |
After noticing #4050, i'd like to bump this PR a bit. |
Oops sorry for letting this fester. We should stay with the bevy of birds and give them a larger gap. I like what you did here: If you apply the gap change to the new logo version from #4050, I'm on board! |
In fact, I think we should consider increasing the gap size in the other logo variants too. Better to make the logo "scalable" everywhere rather than having two versions. |
(but im happy to defer that decision until later if you just want to sort out the simpleicons situation first) |
I think, in this PR i will just update the simpleicon with the new logo from #4050. And open a new PR for the other icons. Will do that tomorrow, need to go to bed now. 😴 |
a95ee53
to
5bf6260
Compare
Ok done. Follow up PR is #4061. |
Blocking this on #4061, and then we can merge these all at once. |
Closed (backlog cleanup), tracked in #15584 . |
Objective
Improve the Bevy simpleicons for smaller sizes. This change makes it look like this:
It is still not perfect at the smallest size. I don't think using just one bird is a good idea, because one bird is not a community and with only one bird it would look too similar to the twitter logo, which could result in some legal worries.
If you have different ideas, please voice them here. If you want to test and view them yourselves, just copy the path out of your SVG file and paste it here https://petershaggynoble.github.io/SI-Sandbox/preview/.
PS: The upstream (simpleicons.org) PR is this one simple-icons/simple-icons#7076. I will update it as soon as this PR is merged.
EDIT: Updated the simpleicon to the improved version from #4050.