Skip to content

Improve bevy icons for better "scalability" #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Weasy666
Copy link
Contributor

Objective

Follow up to #3728.

@cart mentioned that increasing the gap size of the birds in the logo should be done for all icons, to make them scale better.

Right now, i have not committed anything to this branch/PR. I wanted to first discuss how i should handle the gap between the icon and text.

Logo + Text

Current

bevy_logo_dark_3

Logo with increased gap but same banner size (notice the decreased gap between logo and text)

bevy_logo_dark_2

Logo with increased gab and increased banner size (gap between logo and text is the same as in the current banner)

bevy_logo_dark_1
(in this example, the width increased from 416 px to 422 px)

Logo

Current

icon

Increased gap

icon

Let me know which Logo + Text you prefer and i will push that variant.

PS: The changed bevy_bird_simpleicons.svg should vanish after #3728 gets merged, i created a branch from that PR.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 28, 2022
@Weasy666 Weasy666 changed the title Improve bevy simpleicon for smaller sizes Improve bevy icons for better "scalability" Feb 28, 2022
@bjorn3
Copy link
Contributor

bjorn3 commented Feb 28, 2022

I feel like it becomes less clear that it represents three birds and more a single bird and two weird shapes.

@alice-i-cecile alice-i-cecile added A-Meta About the project itself and removed S-Needs-Triage This issue needs to be labelled labels Feb 28, 2022
@alice-i-cecile
Copy link
Member

Mild preference for increased spacing on the banner.

Strong prefererence for the increased gap between the birds.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Weasy666 can you take this out of draft mode?

I'd like to merge this + #3728 together.

@Weasy666 Weasy666 marked this pull request as ready for review May 16, 2022 20:02
@Weasy666
Copy link
Contributor Author

Weasy666 commented May 16, 2022

Sure, done!

Oh wait. Let me take a look on which variant is actually pushed...ah...currently none of the banners is pushed...i remember, i was still waiting on a decision on which one i should push.

@alice-i-cecile
Copy link
Member

It's not a major difference either way; pick whichever one you like best :)

@Weasy666
Copy link
Contributor Author

Weasy666 commented May 17, 2022

OK...i picked Logo with increased gab and increased banner size and modified all svgs and their respective pngs accordingly.

@IceSentry
Copy link
Contributor

Might just be because I'm not on mobile, but the increased gap seems a bit too increased. Especially when looking at the one for simple icons using a single color. I agree with the general idea, but I'd like to see it with a somewhat smaller gap

@alice-i-cecile
Copy link
Member

Yeah, consensus is emerging that the gap is a bit too big. @Weasy666, if you're up for it I think it would be cleaner to merge the changes from #3728 into this PR; I want to merge both at once anyways.

@Weasy666
Copy link
Contributor Author

Well, this is all based on the icon from #3728...so...if you want me to change the gaps between the birds again, then we need to also change the simpleicons one again. The spacing between the bird and the text is the same as before.

btw, i noticed i missed to push the changed icon.svg and it looks like i have exported a wrongly sized bevy_logo_light.png.

@TimJentzsch
Copy link
Contributor

Personally I would prefer two or three versions of the logo, based on the size. I don't think we can find a gap size that fits well for the super small and super big sizes. Especially considering the size difference of the badges to the website logo.

@Weasy666
Copy link
Contributor Author

A few month ago @cart was not a fan of having different versions of the icons, dunno if he has changed his mind in the meantime. #3728 (comment)

@alice-i-cecile alice-i-cecile added the X-Controversial There is active debate or serious implications around merging this PR label May 17, 2022
@alice-i-cecile
Copy link
Member

Adding the controversial label; I think this needs a final call from @cart.

@cart
Copy link
Member

cart commented May 17, 2022

Yeah I think I'd prefer to not have a bunch of different versions of the logo bouncing around. Too easy for someone to pick the "wrong" one. I agree that the spacing feels "too big". Its worth considering a slightly smaller gap, but I'm a bit worried that any gap increase will make the logo feel "worse".

@Weasy666
Copy link
Contributor Author

For me, it looks kinda like we are running in circles and i am slowly loosing my motivation here 😅
Sorry if this sounds kinda harsh, that is not my intention 🙂, but now we are more or less back to where we were at #3728

@cart
Copy link
Member

cart commented May 25, 2022

I really appreciate the work you've done so far and if you stop here I certainly won't hold it against you. But I do think this is a conversation thats worth bringing to its conclusion. We have a number of concerns to balance:

  1. Logo scalability at small sizes
  2. Perceived logo quality at "normal" sizes
  3. Logo consistency (ideally just one version)

Finding the right balance is a matter of aesthetic taste and given that I am the arbiter of that taste atm, it will either involve a lot of back and forth with me to tweak, or me taking ownership of the work. I'm happy to take ownership of the work, but I can't say this is my highest priority atm.

@Weasy666
Copy link
Contributor Author

Thank you! ❤ I have no problem with the conversation per se, it's quite the opposite.
I was just a bit frustrated, because i was under the impression that we already had checked 1. and 2. off in #3728.
So, if we don't have those points checked off, then we also need to touch #3728 again after we have come to a conclusion here, right?
Can you point me in a direction regarding the too big gap? How big should it be, compared to the original and current gap?

@cart
Copy link
Member

cart commented May 26, 2022

Cool cool! From my perspective, in #3728 I only expressed that (a) a single logo version has my preference and (b) it is worth exploring increasing the gap in that unified version. Then this pr gave that a whack and we've largely agreed that the gap is too big.

Can you point me in a direction regarding the too big gap? How big should it be, compared to the original and current gap?

Lets try splitting the difference (half way between the original and current gap) and rendering that at a variety of sizes.

@bas-ie
Copy link
Contributor

bas-ie commented Oct 2, 2024

Closed (backlog cleanup), tracked in #15584.

@bas-ie bas-ie closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta About the project itself X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants