-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Improve bevy icons for better "scalability" #4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I feel like it becomes less clear that it represents three birds and more a single bird and two weird shapes. |
Mild preference for increased spacing on the banner. Strong prefererence for the increased gap between the birds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done! Oh wait. Let me take a look on which variant is actually pushed...ah...currently none of the banners is pushed...i remember, i was still waiting on a decision on which one i should push. |
It's not a major difference either way; pick whichever one you like best :) |
OK...i picked |
Might just be because I'm not on mobile, but the increased gap seems a bit too increased. Especially when looking at the one for simple icons using a single color. I agree with the general idea, but I'd like to see it with a somewhat smaller gap |
Well, this is all based on the icon from #3728...so...if you want me to change the gaps between the birds again, then we need to also change the simpleicons one again. The spacing between the bird and the text is the same as before. btw, i noticed i missed to push the changed |
Personally I would prefer two or three versions of the logo, based on the size. I don't think we can find a gap size that fits well for the super small and super big sizes. Especially considering the size difference of the badges to the website logo. |
A few month ago @cart was not a fan of having different versions of the icons, dunno if he has changed his mind in the meantime. #3728 (comment) |
Adding the controversial label; I think this needs a final call from @cart. |
Yeah I think I'd prefer to not have a bunch of different versions of the logo bouncing around. Too easy for someone to pick the "wrong" one. I agree that the spacing feels "too big". Its worth considering a slightly smaller gap, but I'm a bit worried that any gap increase will make the logo feel "worse". |
For me, it looks kinda like we are running in circles and i am slowly loosing my motivation here 😅 |
I really appreciate the work you've done so far and if you stop here I certainly won't hold it against you. But I do think this is a conversation thats worth bringing to its conclusion. We have a number of concerns to balance:
Finding the right balance is a matter of aesthetic taste and given that I am the arbiter of that taste atm, it will either involve a lot of back and forth with me to tweak, or me taking ownership of the work. I'm happy to take ownership of the work, but I can't say this is my highest priority atm. |
Thank you! ❤ I have no problem with the conversation per se, it's quite the opposite. |
Cool cool! From my perspective, in #3728 I only expressed that (a) a single logo version has my preference and (b) it is worth exploring increasing the gap in that unified version. Then this pr gave that a whack and we've largely agreed that the gap is too big.
Lets try splitting the difference (half way between the original and current gap) and rendering that at a variety of sizes. |
Closed (backlog cleanup), tracked in #15584. |
Objective
Follow up to #3728.
@cart mentioned that increasing the gap size of the birds in the logo should be done for all icons, to make them scale better.
Right now, i have not committed anything to this branch/PR. I wanted to first discuss how i should handle the gap between the icon and text.
Logo + Text
Current
Logo with increased gap but same banner size (notice the decreased gap between logo and text)
Logo with increased gab and increased banner size (gap between logo and text is the same as in the current banner)
(in this example, the width increased from 416 px to 422 px)
Logo
Current
Increased gap
Let me know which
Logo + Text
you prefer and i will push that variant.PS: The changed
bevy_bird_simpleicons.svg
should vanish after #3728 gets merged, i created a branch from that PR.