lighting.rs example: Improved ambient light showcase #19658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ambient light now has a reasonable brightness (previous value 0.02 is so dim it makes no difference) - Pressing space bar toggles ambient light to showcase it's effect - Text added to show current state of the ambient light (on, off) and the keybind to toggle it
JMS55
approved these changes
Jun 15, 2025
alice-i-cecile
approved these changes
Jun 15, 2025
alice-i-cecile
added
A-Rendering
alice-i-cecile
added
the
M-Deliberate-Rendering-Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
As someone who is currently learning Bevy, I found the implementation of the ambient light in the 3d/lighting.rs example unsatisfactory.
Solution
I'm very new to Bevy and Rust, so apologies if any of this code is not up to scratch.
Testing
I checked all the text still updates correctly and all keybinds still work. In my testing, it looks to work okay.
I'd appreciate others testing too, just to make sure.
Showcase
Click to view showcase