Skip to content

Move TextShadow to text widget module #19579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Move TextShadow to text widget module #19579

wants to merge 5 commits into from

Conversation

ickshonpe
Copy link
Contributor

Objective

It's odd that TextShadow is accessible by importing bevy::ui::* but Text isn't.

Move the TextShadow component to text widget module and move its type registration to the build_text_interop function.

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 11, 2025
@TotalKrill TotalKrill self-requested a review June 14, 2025 14:13
TotalKrill
TotalKrill approved these changes Jun 14, 2025
View reviewed changes
Copy link
Contributor

@TotalKrill TotalKrill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, makes import logic easier to understand imho

andriyDev
andriyDev approved these changes Jun 17, 2025
View reviewed changes
release-content/migration-guides/textshadow_is_moved_to_widget_text_module.md
Comment on lines +7 to +12






Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all these empty lines (except one).

@andriyDev
Copy link
Contributor

Looks like this also needs another merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TotalKrill TotalKrill TotalKrill approved these changes

@andriyDev andriyDev andriyDev approved these changes

Assignees
No one assigned
Labels
A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @andriyDev @TotalKrill