Skip to content

Rename JustifyText to Justify #19522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Rename JustifyText to Justify #19522

wants to merge 6 commits into from
+75 −67

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jun 7, 2025 •
edited
Loading

Objective

Rename JustifyText:

  • The name JustifyText is just ugly.
  • It's inconsistent since no other bevy_text types have a Text- suffix, only prefix.
  • It's inconsistent with the other text layout enum Linebreak which doesn't have a prefix or suffix.

Fixes #19521.

Solution

Rename JustifyText to Justify.

Without other context, it's natural to assume the name Justify refers to text justification.

@ickshonpe ickshonpe changed the title Renamed JustifyText to Justify Rename JustifyText to Justify Jun 7, 2025
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

alice-i-cecile
alice-i-cecile reviewed Jun 7, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once there's a migration guide file :)

alice-i-cecile
alice-i-cecile reviewed Jun 8, 2025
View reviewed changes
@alice-i-cecile alice-i-cecile requested a review from viridia June 8, 2025 06:22
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viridia viridia viridia approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@VitalyAnkh VitalyAnkh VitalyAnkh approved these changes

Assignees
No one assigned
Labels
A-Text Rendering and layout for characters C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename JustifyText
4 participants
@ickshonpe @viridia @alice-i-cecile @VitalyAnkh