Fix iOS simulator build #19498
Merged
Fix iOS simulator build #19498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
C-Bug
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
madsmtm
force-pushed
the
fix-ios-simulator
branch
from
54f47e3 to
b97696d
Compare
madsmtm
force-pushed
the
fix-ios-simulator
branch
from
b97696d to
9ddbadf
Compare
|
If you're planning a v0.16.2 release, I'd recommend that this goes in that. @simlay has kindly tested |
|
Oops, sorry, I didn't test with |
By updating to dependency versions that don't depend on bindgen.
madsmtm
force-pushed
the
fix-ios-simulator
branch
from
9ddbadf to
a17ce1d
Compare
|
I went with depending on the patched version of (This makes the upgrade easier to backport, and means that we don't have to wait for RustAudio/rodio#721). |
madsmtm
added
S-Needs-Review
mockersf
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #18893.
Solution
bindgencurrently has issues with building Xcode 16.3 and above, due to Clang being more strict about target triples. It was fixed in rust-lang/rust-bindgen#3182, but as a breaking release, so affected dependencies have to be updated to either not depend onbindgen, or depend on a fixed version of it:tracing-oslog: Pregenerate bindings Absolucy/tracing-oslog#12coreaudio-sys: Bump bindgen to 0.72.0 and coreaudio-sys to 0.2.17 RustAudio/coreaudio-sys#114Testing
With Xcode 16.3 or 16.4.