Skip to content

Conversation

dvdsk
Copy link
Member

@dvdsk dvdsk commented Mar 27, 2025

Chores:

  • check upgrade guide
  • write announcement
  • put release date in CHANGELOG
  • update examples link in README

@PetrGlad
Copy link
Collaborator

There are may API changes. 0.30 maybe?

// Who does not like bike-shedding?

@dvdsk
Copy link
Member Author

dvdsk commented Mar 28, 2025

There are may API changes. 0.30 maybe?

luckily we do not need to make that decision, semver (https://semver.org) has done it for us :)

I do like the idea of a 1.0.0 eventually. We can probably do that after:

  • solving the span silliness
  • replacing Sink with something that handles crossfade gracefully

@PetrGlad
Copy link
Collaborator

PetrGlad commented Mar 29, 2025

As you mentioned already thousands of projects depend on it and it is sad fact of live that people generally do not read documentation, including semantic versioning guides. No problem picking next minor version, of course.

@dvdsk
Copy link
Member Author

dvdsk commented Mar 29, 2025

I'll place an announcement on reddit and the rust user forum noting its a breaking release and explicitly mention the upgrade guide and documentation.

maybe that will help

@dvdsk
Copy link
Member Author

dvdsk commented Mar 31, 2025

Ready for review and then release. I would prefer to release either next monday or before friday this week. Since during the weekend I can not handle any fallout/questions.

@roderickvd
Copy link
Collaborator

On a business trip now, could offer a few nitpicks but would have to do it on mobile (biggest one: gapless is only with Symphonia, and already was in 0.20 - biggest fix here is the availability of total_duration).

Come to think of, there are also some function return type changes in the Source trait that users who implement that need to know about.

Overarching question: the way I perceive the upgrade guide, it's indeed to migrate and fix compilation issues. I'm wondering if we should shed a little more light on some internals; the f32 pipeline and why we moved away from the generics?

@dvdsk
Copy link
Member Author

dvdsk commented Apr 1, 2025

another thing, bincode has the migration guide in the docs, seems like a good idea to me.

@dvdsk
Copy link
Member Author

dvdsk commented Apr 1, 2025

blocked by #724

Copy link
Collaborator

@roderickvd roderickvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@dvdsk
Copy link
Member Author

dvdsk commented Apr 4, 2025

Some suggestions.

thank you very much, I'll get on that some day next week. Next time full free to edit the code/docs on the branch directly. Then I'll just look at the diff and bring up any contentious change.

@roderickvd
Copy link
Collaborator

blocked by #730

@dvdsk
Copy link
Member Author

dvdsk commented May 12, 2025

rebased on main

@dvdsk dvdsk mentioned this pull request May 22, 2025
@dvdsk dvdsk force-pushed the 0.21 branch 3 times, most recently from 6d9b6c9 to d58968b Compare June 4, 2025 21:35
@dvdsk
Copy link
Member Author

dvdsk commented Jun 4, 2025

rebased on master

@dvdsk dvdsk force-pushed the 0.21 branch 3 times, most recently from ac0b1b8 to 946cce2 Compare June 4, 2025 22:28
@dvdsk dvdsk marked this pull request as ready for review June 4, 2025 22:30
@dvdsk
Copy link
Member Author

dvdsk commented Jun 4, 2025

we should be good to release now :)

@dvdsk dvdsk requested review from roderickvd and PetrGlad June 4, 2025 22:30
@madsmtm
Copy link
Contributor

madsmtm commented Jun 10, 2025

Mind if I suggest you include #754 in this release as well?

@dvdsk
Copy link
Member Author

dvdsk commented Jul 5, 2025

Okay this is rebased on main now. I think we are still missing some stuff in the upgrade guide related to the feature overhaul. Would you mind giving that a look @roderickvd?

@roderickvd roderickvd requested a review from Copilot July 12, 2025 13:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the 0.21.0 release by updating the announcement, bumping versions, linking the upgrade guide, and refreshing documentation/changelog.

  • Drafts and corrects the outreach announcement
  • Expands and updates the UPGRADE guide with new migration steps
  • Updates README, Cargo.toml, and CHANGELOG.md for version 0.21.0

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
outreach/v0.21_announcement.md Draft release announcement for social channels
UPGRADE.md New upgrade instructions and examples for 0.21.0 migration
README.md Added “Breaking Changes” section and bumped example version
Cargo.toml Bumped crate version to 0.21.0
CHANGELOG.md Inserted new 0.21.0 section and reformatted older entries
Comments suppressed due to low confidence (5)

UPGRADE.md:5

  • [nitpick] Use a consistent heading level here (e.g. '##') rather than another top-level '#'.
# rodio 0.21 to current GitHub version

UPGRADE.md:7

  • [nitpick] Clarify this placeholder—consider replacing with 'No changes are required.' for readability.
nothing

UPGRADE.md:15

  • Add a leading hyphen to maintain list formatting, e.g. '- To revert to the old decoders…'.
  to revert to the old decoders, you need to disable default-features and enable the `claxon`, `hound` and `lewton` features in `Cargo.toml` for respectively FLAC, WAV and Ogg Vorbis.

CHANGELOG.md:12

  • Replace '(TODO)' with the actual release date in the same format as other entries (e.g. '- YYYY-MM-DD').
## Version [0.21] (TODO)

UPGRADE.md:71

  • The example uses an undefined music.ogg; it should likely be the opened file or a BufReader instance.
let source = Decoder::try_from(music.ogg)?;

@roderickvd
Copy link
Collaborator

Okay this is rebased on main now. I think we are still missing some stuff in the upgrade guide related to the feature overhaul. Would you mind giving that a look @roderickvd?

As the upgrade guide contains required code changes, and does not aim to replace the changelog, I think the upgrade contents on features is good enough.

I did go through it to improve readability.

@dvdsk
Copy link
Member Author

dvdsk commented Jul 12, 2025

rebases on main

@dvdsk dvdsk merged commit f7aa48d into master Jul 12, 2025
9 checks passed
@roderickvd
Copy link
Collaborator

Congratulations to all contributors on this new and pretty hefty release.

Should we do some communication on it on the socials? I think we did previously on Reddit.

@dvdsk
Copy link
Member Author

dvdsk commented Jul 13, 2025

Should we do some communication on it on the socials? I think we did previously on Reddit.

Almost forgot 😅

I've just done reddit, we will also get a channel and a announcement in the rust audio discord. If you know any other places please do go ahead and post there too. We've got the announcement text ready in outreach/v0.21_announcement.md

@dvdsk dvdsk deleted the 0.21 branch July 14, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants