Remove ArchetypeComponentId and archetype_component_access
#19143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge archetype_component_access and new_archetype methods into run_unsafe and get_param.
chescock
added
A-ECS
ElliottjPierce
approved these changes
May 9, 2025
ItsDoot
approved these changes
May 10, 2025
There was a problem hiding this comment.
I like it! This should make queries as entities straightforward now, right?
Some stats on memory savings on 64-bit systems:
-8 bytesper component per archetype-8 bytesper resource-4 bytesper system (SystemState)- at least
-128 bytesper system (SystemMeta) - at least
-128 bytesper combinator system - at least
-128 bytesper pipe system
ItsDoot
added
S-Ready-For-Final-Review
NthTensor
approved these changes
May 18, 2025
|
@chescock merge conflicts are non-trivial. Can you fix them up so I can get this in? |
alice-i-cecile
added
S-Waiting-on-Author
…component-id # Conflicts: # crates/bevy_ecs/src/system/system_param.rs
chescock
added
S-Ready-For-Final-Review
@alice-i-cecile Should be fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Remove
ArchetypeComponentIdandarchetype_component_access. Following #16885, they are no longer used by the engine, so we can stop spending time calculating them or space storing them.Solution
Remove
ArchetypeComponentIdand everything that touches it.The
System::update_archetype_component_accessmethod no longer needs to updatearchetype_component_access. We do still need to update query caches, but we no longer need to do so before running the system. We'd have to touch every caller anyway if we gave the method a better name, so just removeSystem::update_archetype_component_accessandSystemParam::new_archetypeentirely, and update the query cache inQuery::get_param.The
SingleandPopulatedparams also need their query caches updated inSystemParam::validate_param, so changevalidate_paramto take&mut Self::Stateinstead of&Self::State.