Enable wayland by default

[kobutri]

What problem does this solve or what need does it fill?

Without enabling wayland bevy fails on systems that support wayland instead of falling back to x11, supported by xwayland.
This is because wgpu won't support x11 windows, when wayland is available on the system.

What solution would you like?

simply add "wayland" to the default features list.

What alternative(s) have you considered?

You can of course enable it manually, but many will forget and simply assume that wayland will be supported via xwayland.

[bjorn3]

It may also be nice to default to X11 (through Xwayland) on GNOME even when wayland is supported as GNOME refuses to properly implement some parts of wayland. For example they don't support server side decorations, so winit has to draw a rather ugly title bar itself instead.

[kobutri]

That would be a bad idea, because wgpu's gles backend will always use wayland when possible.
There is some discussion in winit and smithay_client_toolkit about adding libdecor support, for wayland, but for now we have to live with not the prettiest solution.

[bjorn3]

That would be a bad idea, because wgpu's gles backend will always use wayland when possible.

Then that is already a problem when wayland support is entirely disabled in winit. gfx-rs has logic to recreate the egl context when creating a surface for a different wayland window. I feel like this logic could be extended to recreating the egl context when creating a surface for an xcb or xlib window.

[heavyrain266]

GNOME will never add SSD because they asume that everyone uses GTK and prefered to implement titlebars with additional buttons, menus etc. as CSD thing...

About libdecor, I found out it as kind of library which isn't FFI friendly at all and getting it stabilized in SCTK may take months.

[mockersf]

What's the impact of enabling Wayland when running somewhere it's not available? Longer build times? Larger binaries?

[kirusfg]

Regarding the topic of SSD in Gtk: I have stumbled upon this issue in a Wayland compositor and there is a PR to fix this issue in Gtk by enabling optional SSD (judging from the description, that is what it does; correct me if I am wrong).

Might be of interest to you @heavyrain266.

[heavyrain266]

Regarding the topic of SSD in Gtk: I have stumbled upon this issue in a Wayland compositor and there is a PR to fix this issue in Gtk by enabling optional SSD (judging from the description, that is what it does; correct me if I am wrong).

Might be of interest to you @heavyrain266.

That doesn't fix absence of SSD in Mutter itself (GNOME's compositor) but adds option that you can disable GTK CSD in your Compositor to use your own SSD implementation.

[mcobzarenco]

What alternative(s) have you considered?
You can of course enable it manually, but many will forget and simply assume that wayland will be supported via xwayland.

For GNOME in Ubuntu, that would mean having to manually disable it to continue to use x11 (as this comment notes)?

[kobutri]

For GNOME in Ubuntu, that would mean having to manually disable it to continue to use x11 (as this comment notes)?

XWayland is currently broken for wgpu with gles as it is will create an Instance that is only compatible with wayland if wayland is available.