Skip to content

Derive PartialEq for ImageSampler #19105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Derive PartialEq for ImageSampler #19105

wants to merge 1 commit into from
+6 −6

Conversation

Noxmore
Copy link
Contributor

@Noxmore Noxmore commented May 6, 2025 •
edited
Loading

Objective

Ran into a situation where I need to compare two image samplers. My current workaround is to compare the Debug outputs

Solution

Derive PartialEq on ImageSampler and structs in its fields.

Testing

Full CI passed.

@IQuick143 IQuick143 added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IQuick143 IQuick143 IQuick143 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noxmore @IQuick143