Added StableInterpolate implementations for linear colors.
#18601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Feature
greeble-dev
reviewed
Mar 29, 2025
There was a problem hiding this comment.
Could consider reusing impl_componentwise_vector_space? b8d7c35
greeble-dev
approved these changes
Mar 29, 2025
IQuick143
reviewed
Mar 29, 2025
| #[test] | ||
| pub fn test_color_stable_interpolate() { | ||
| let b = Srgba::BLACK; | ||
| let w = Srgba::WHITE; |
There was a problem hiding this comment.
🤔 Is Srgba actually a linear space?
There was a problem hiding this comment.
I could be wrong but I think the point of color spaces is to use them in a linear space.
IQuick143
approved these changes
Mar 29, 2025
JaySpruce
added
S-Ready-For-Final-Review
|
This isn't the place to get into it I guess, but I'm increasingly of the feeling that the color types shouldn't implement That said, all of the colors can still actually implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Colors currently do not implement
StableInterpolate, which makes them ineligible for functions likesmooth_nudgeand make some generic APIs awkward.Solution
Implemented
StableInterpolatefor linear color types that should be uncontroversial. Non-linear types likeHslare not implemented in this PR.Testing
Added a test that checks implementations are correct.